From owner-freebsd-bugs@FreeBSD.ORG  Fri Feb  8 23:20:00 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id B8351B5F
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Fri,  8 Feb 2013 23:20:00 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 9ED25909
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Fri,  8 Feb 2013 23:20:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r18NK0EV094568
 for <freebsd-bugs@freefall.freebsd.org>; Fri, 8 Feb 2013 23:20:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r18NK0Bo094566;
 Fri, 8 Feb 2013 23:20:00 GMT (envelope-from gnats)
Resent-Date: Fri, 8 Feb 2013 23:20:00 GMT
Resent-Message-Id: <201302082320.r18NK0Bo094566@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Sascha Wildner <swildner@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id BF2A6B53
 for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Feb 2013 23:18:54 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 8F119902
 for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Feb 2013 23:18:54 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r18NIsKm094981
 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Feb 2013 23:18:54 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r18NIsI3094980;
 Fri, 8 Feb 2013 23:18:54 GMT (envelope-from nobody)
Message-Id: <201302082318.r18NIsI3094980@red.freebsd.org>
Date: Fri, 8 Feb 2013 23:18:54 GMT
From: Sascha Wildner <swildner@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: misc/175974: logic issue in ppp(8)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2013 23:20:00 -0000


>Number:         175974
>Category:       misc
>Synopsis:       logic issue in ppp(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 08 23:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Sascha Wildner
>Release:        seen on current
>Organization:
DragonFly BSD
>Environment:
>Description:
usr.sbin/ppp/mppe.c has the following check in line 171:

if (*proto < 0x21 && *proto > 0xFA) {

My assumption is that it should be an || but I lack the MPPE clue to verify it.

Best regards,
Sascha

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: