From owner-freebsd-current@FreeBSD.ORG  Sat Aug 13 09:26:31 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F84616A41F
	for <current@FreeBSD.org>; Sat, 13 Aug 2005 09:26:31 +0000 (GMT)
	(envelope-from sos@FreeBSD.org)
Received: from spider.deepcore.dk
	(cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk
	[80.166.201.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 83E0D43D45
	for <current@FreeBSD.org>; Sat, 13 Aug 2005 09:26:30 +0000 (GMT)
	(envelope-from sos@FreeBSD.org)
Received: from [194.192.25.136] (mac.deepcore.dk [194.192.25.136])
	by spider.deepcore.dk (8.13.3/8.13.3) with ESMTP id j7D9Q0gJ023981;
	Sat, 13 Aug 2005 11:26:00 +0200 (CEST)
	(envelope-from sos@FreeBSD.org)
In-Reply-To: <42FCE289.4070901@cox.net>
References: <42FBEA3A.5090809@cox.net>
	<22CD48F3-747D-48EB-A5CF-633FB78BCA8D@FreeBSD.org>
	<42FCE289.4070901@cox.net>
Mime-Version: 1.0 (Apple Message framework v733)
Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed
Message-Id: <DABE4116-EE59-463C-8AB6-D4E2F66B9E64@FreeBSD.org>
Content-Transfer-Encoding: quoted-printable
From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org>
Date: Sat, 13 Aug 2005 11:26:22 +0200
To: Vadim Chekan <vchekan@cox.net>
X-Mailer: Apple Mail (2.733)
X-mail-scanned: by DeepCore Virus & Spam killer v1.12
Cc: current@FreeBSD.org
Subject: Re: [Patch] Serial ATAPI is not recognized
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Aug 2005 09:26:31 -0000


On 12/08/2005, at 19:55, Vadim Chekan wrote:

> S=F8ren Schmidt wrote:
>>
>> SATA/ATAPI is not supported yet, and the above patch is by far =20
>> not  enough for all systems to work.
>> In fact you are just lucky on your system, for the heck of it I =20
>> tried  it here and my test system lost all its SATA disks :)
>> Support is in the works and will hit -current when its stable =20
>> enough  for general usage....
>>
> Then I'll be one of the first who check this support.
> Thanks for your job!
>
> BTW, I was a little bit puzzled by the code in
> ata-chipset.c:ata_achi_allocate()
> /* XXX SOS this is a hack to satisfy various legacy cruft */
>    ch->r_io[ATA_CYL_LSB].res =3D ctlr->r_res2;
>    ch->r_io[ATA_CYL_LSB].offset =3D ATA_AHCI_P_SIG + 1 + offset;
>    ch->r_io[ATA_CYL_LSB].res =3D ctlr->r_res2;
>    ch->r_io[ATA_CYL_MSB].offset =3D ATA_AHCI_P_SIG + 3 + offset;
>
>
> If I understand the logic of the code correct, in the line before =20
> last should be ATA_CYL_MSB, not ATA_CYL_LSB. Looks like it's typo =20
> and ch->r_io[ATA_CYL_MSB].res is never initialized by this code. =20
> Neither I can find where it is initialized at all. But somehow it =20
> works !?

Thats a bug alright, however its not used as the AHCI support doesn't =20=

understand ATAPI yet, so the code should newer be used (but it will =20
fail to recon ATAPI devices).


- S=F8ren