From owner-svn-src-all@freebsd.org Wed Jan 24 19:27:44 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B70FEC0C67 for ; Wed, 24 Jan 2018 19:27:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DDE31734D4 for ; Wed, 24 Jan 2018 19:27:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-wm0-x244.google.com with SMTP id g1so10465370wmg.2 for ; Wed, 24 Jan 2018 11:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4UJAl2UoqyiSCPSCzE/gGvC0aICWsqXE6hX9Y75LiM0=; b=KViFiAIYREOYKD1uMCGZIjAsVCtpb9cACholmN/NU+2kMQOk658p8MR4juxJ6APW96 pfkWMT6moGSov6Tud5zdQXBpSQp3D/N+pJs+XPNrr9kjJMix8odc79kIzdb6/GZ4D7qv oQKBWQZ/hXQ61rXltonBdl5iJtDmzIOpAvCpICNWQpumQzIcSTKoEb1EYmvAIr/ZQyKn fyJ8K+mOobyXJ+CxVRmSR392g1y38XCRsz43p+bFnayC/SKnZ1Nn378AOFCq4xm/ubNf jNpb1HKM88J6vLqvsY+bHbKfZJ3Efz1+//QHwft+thUcGTzotB/qwG7pL1drDjjFaIvy LVkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4UJAl2UoqyiSCPSCzE/gGvC0aICWsqXE6hX9Y75LiM0=; b=fafQ77e9npXpsymuIQl1jwSlYPCpBG60JYxZ2qHTLEQsLflj7/RmKVO75U2Xcxury8 pUHHE7A8Ra3wwb7uwroS1JJmIBy8ToDXbfJViT5qmZtXbS5vo0SY7/YWgyexPY5lUnR2 Htxu9YTC6T3wIUf7SiMso/yFu3cHa+EB4enDHvYwrMUOh753Slj5D1aywLDYSfF2VCdy LSpPjopK3BUhxgqDwbawiHu+RiIsmPR6TaZHCkjPXH6ss1nbsFfyXsxkkvYHf+OG5jZR UpGu2bx2BX6iKqyB0MyMpwtkcNnTXFGFZVTTC6UZY16wRkYDRQOrItXrlNmAtoq60PVM MSww== X-Gm-Message-State: AKwxyteNAO/biQjXzdYVzyYEH4VHDSXZOwppCir1+SBkYExPiq6gegpB yR3veIwm/pEOl4BLvh0JecT+YJNsSwFE+A4YYQyH4A== X-Google-Smtp-Source: AH8x224/15VbwXfIlKhLbB3uqEDoKyHOP8s1iBLH+ZLFi8/2y1+temxQ6JE6GUwdkC3j7MNrMymeq+nR+2nRMBlsDpI= X-Received: by 10.80.217.202 with SMTP id x10mr20165878edj.118.1516822062742; Wed, 24 Jan 2018 11:27:42 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.80.133.195 with HTTP; Wed, 24 Jan 2018 11:27:42 -0800 (PST) X-Originating-IP: [2607:fb90:6e68:68b0:2c74:a381:7e69:9962] Received: by 10.80.133.195 with HTTP; Wed, 24 Jan 2018 11:27:42 -0800 (PST) In-Reply-To: References: <201801211542.w0LFgbsp005980@repo.freebsd.org> <51ff8aef-5660-7857-e4d5-12cdc77bc071@FreeBSD.org> <20180124182548.X1063@besplex.bde.org> <1516817048.42536.182.camel@freebsd.org> <2aa48cbd-247a-66cd-b486-02ee77ec2e96@selasky.org> From: Warner Losh Date: Wed, 24 Jan 2018 12:27:42 -0700 X-Google-Sender-Auth: QbpB8D85i3rYYgotEJS9ajZR2Rg Message-ID: Subject: Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/... To: "Conrad E. Meyer" Cc: Pedro Giffuni , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 19:27:44 -0000 On Jan 24, 2018 12:24 PM, "Conrad Meyer" wrote: On Wed, Jan 24, 2018 at 10:51 AM, Pedro Giffuni wrote: > FWIW, I suggested a panic for M_WAITOK and returning NULL for M_NOWAIT, but > cem didn't like it because it was inconsistent. > > I think the current argument is more about the size/trigger than the > behavior though. Yeah. If an overflow happens in a path, we want to flag it -- regardless of whether that was a M_NOWAIT or M_WAITOK request. Which is why we should add check overflows for most of the no wait cases. They should be checked, but not primarily with mallocarray... Warner