From owner-freebsd-x11@FreeBSD.ORG Wed Jan 1 18:00:03 2014 Return-Path: Delivered-To: freebsd-x11@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9BD70B4C for ; Wed, 1 Jan 2014 18:00:03 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 87CF217AE for ; Wed, 1 Jan 2014 18:00:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s01I02p3072959 for ; Wed, 1 Jan 2014 18:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s01I02mJ072958; Wed, 1 Jan 2014 18:00:02 GMT (envelope-from gnats) Date: Wed, 1 Jan 2014 18:00:02 GMT Message-Id: <201401011800.s01I02mJ072958@freefall.freebsd.org> To: freebsd-x11@FreeBSD.org Cc: From: John Marino Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all have same error X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: John Marino List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2014 18:00:03 -0000 The following reply was made to PR ports/184952; it has been noted by GNATS. From: John Marino To: Koop Mast Cc: bug-followup@FreeBSD.org, zeising@FreeBSD.org Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all have same error Date: Wed, 01 Jan 2014 18:56:05 +0100 On 1/1/2014 10:19, Koop Mast wrote: > I have trouble seeing what is exactly broken with the WITH_NEW_XORG > detection. On the survace it seems to work. Can you explain where it > doesn't work? > > root@crashalot:/usr/ports/x11-servers/xephyr # ident Makefile > Makefile: > $FreeBSD: head/x11-servers/xephyr/Makefile 338299 2013-12-31 > 13:22:14Z kwm $ > root@crashalot:/usr/ports/x11-servers/xephyr # make -V PORTVERSION > 1.12.4 Koop, Were you addressing Niclas? He claimed your commit broke it. At first I said, "well detection must be broken in that case", but after thinking about it, I questioned Niclas if it was actually broken. Since xorg-server still pulls in bsd.port.options.mk, the detection should still work (as you note). So right now, I'm working under the assumption there is actually no breakage at all, and Niclas just said the ports were broken without verifying first. If that assumption is wrong, he should correct it. Regards, John