From owner-svn-src-all@freebsd.org Wed Jul 8 23:27:31 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D507997364; Wed, 8 Jul 2015 23:27:31 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 322B01630; Wed, 8 Jul 2015 23:27:30 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t68NRUwh032946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 8 Jul 2015 16:27:30 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t68NRUHA032945; Wed, 8 Jul 2015 16:27:30 -0700 (PDT) (envelope-from jmg) Date: Wed, 8 Jul 2015 16:27:30 -0700 From: John-Mark Gurney To: Pedro Giffuni Cc: Luigi Rizzo , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285284 - head/lib/liblzma Message-ID: <20150708232729.GX8523@funkthat.com> References: <201507081836.t68IacJu069563@repo.freebsd.org> <559D9172.9040305@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559D9172.9040305@FreeBSD.org> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Wed, 08 Jul 2015 16:27:30 -0700 (PDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 23:27:31 -0000 Pedro Giffuni wrote this message on Wed, Jul 08, 2015 at 16:09 -0500: > On 07/08/15 13:36, Luigi Rizzo wrote: > > Author: luigi > > Date: Wed Jul 8 18:36:37 2015 > > New Revision: 285284 > > URL: https://svnweb.freebsd.org/changeset/base/285284 > > > > Log: > > only enable immintrin when clang is used. The base gcc does not support it. > > > > Reviewed by: delphij > > > > Modified: > > head/lib/liblzma/config.h > > > > Modified: head/lib/liblzma/config.h > > ============================================================================== > > --- head/lib/liblzma/config.h Wed Jul 8 18:12:24 2015 (r285283) > > +++ head/lib/liblzma/config.h Wed Jul 8 18:36:37 2015 (r285284) > > @@ -150,7 +150,8 @@ > > #define HAVE_ICONV 1 > > > > /* Define to 1 if you have the header file. */ > > -#if defined(__FreeBSD__) && defined(__amd64__) > > +/* FreeBSD - only with clang because the base gcc does not support it */ > > +#if defined(__clang__) && defined(__FreeBSD__) && defined(__amd64__) > > #define HAVE_IMMINTRIN_H 1 > > #endif > > > > > FWIW, gcc 4.3+ does have it so this may some undesired (but hidden) > effect when building with an external gcc. Looking at the header, immintrin.h, it looks like it's just a catch all for various intrinsic headers... And looking at the lzma code, the immintrin.h include could be replaced w/ an emmintrin.h and things would be fine... Though I don't see sse2 being enabled when compiling the library... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."