From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 26 09:58:56 2007 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6FEF116A407; Thu, 26 Apr 2007 09:58:56 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75]) by mx1.freebsd.org (Postfix) with ESMTP id E582713C4B9; Thu, 26 Apr 2007 09:58:55 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1]) by svm.csie.ntu.edu.tw (8.13.8/8.13.8) with ESMTP id l3Q9ws0w067700; Thu, 26 Apr 2007 17:58:54 +0800 (CST) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: (from rafan@localhost) by svm.csie.ntu.edu.tw (8.13.8/8.13.8/Submit) id l3Q9wsg5050962; Thu, 26 Apr 2007 17:58:54 +0800 (CST) (envelope-from rafan) Date: Thu, 26 Apr 2007 17:58:54 +0800 From: Rong-En Fan To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Message-ID: <20070426095854.GA64372@svm.csie.ntu.edu.tw> References: <200610261858.k9QIwcMJ074538@svm.csie.ntu.edu.tw> <200610261900.k9QJ0ai7004719@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200610261900.k9QJ0ai7004719@freefall.freebsd.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: ale@FreeBSD.org, Rong-En Fan Subject: Re: ports/104838: [PATCH] sysutils/portconf: auto detect real path of /usr/ports X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2007 09:58:56 -0000 I found that ${VAR} != "" does not work as I thought. It should be replaced by empty(). I updated the patch at http://people.freebsd.org/~rafan/portconf.diff Rong-En Fan