From owner-freebsd-current@FreeBSD.ORG  Fri May 29 14:46:24 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 94F3D1065670;
	Fri, 29 May 2009 14:46:24 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 660EC8FC12;
	Fri, 29 May 2009 14:46:24 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 1815B46B2C;
	Fri, 29 May 2009 10:46:24 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id C47B88A029;
	Fri, 29 May 2009 10:46:22 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Andriy Gapon <avg@freebsd.org>
Date: Fri, 29 May 2009 10:41:38 -0400
User-Agent: KMail/1.9.7
References: <4A1FEE04.1060202@freebsd.org>
In-Reply-To: <4A1FEE04.1060202@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905291041.39168.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Fri, 29 May 2009 10:46:22 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE
	autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Rui Paulo <rpaulo@freebsd.org>, Robert Noland <rnoland@freebsd.org>,
	Ariff Abdullah <ariff@freebsd.org>, freebsd-current@freebsd.org,
	Sam Leffler <sam@freebsd.org>, Warner Losh <imp@freebsd.org>
Subject: Re: fixing kobj signatures
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2009 14:46:25 -0000

On Friday 29 May 2009 10:15:32 am Andriy Gapon wrote:
> 
> I think I have completed fixing signatures of kobj method implementations in 
the
> whole head tree.
> The current diff here:
> http://people.freebsd.org/~avg/
> 
> It is quite arbitrarily split into the following files:
> kobj-agp.diff
> kobj-arm.diff
> kobj-linker.diff
> kobj-other.diff
> kobj-sound.diff

I haven't looked at kobj-sound, but the rest of these look fine to me.  I 
would drop the 'XXX' comments from return values in miibus_write_reg() 
routines as 'return (0)' in every case seems to be consistent with other NIC 
drivers.

-- 
John Baldwin