From owner-cvs-all@FreeBSD.ORG Thu Oct 27 06:56:00 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A152616A41F; Thu, 27 Oct 2005 06:56:00 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B75A43D4C; Thu, 27 Oct 2005 06:55:59 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 83BD350F95; Thu, 27 Oct 2005 08:55:57 +0200 (CEST) Received: from localhost (dle176.neoplus.adsl.tpnet.pl [83.24.34.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id EDB47509F1; Thu, 27 Oct 2005 08:55:50 +0200 (CEST) Date: Thu, 27 Oct 2005 08:55:46 +0200 From: Pawel Jakub Dawidek To: Don Lewis Message-ID: <20051027065505.GA668@garage.freebsd.pl> References: <200510032157.j93LvhM7022905@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl" Content-Disposition: inline In-Reply-To: <200510032157.j93LvhM7022905@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: ** X-Spam-Status: No, score=2.6 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL,RCVD_IN_XBL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 06:56:00 -0000 --6WlEvdN9Dv0WHSBl Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 03, 2005 at 09:57:43PM +0000, Don Lewis wrote: +> truckman 2005-10-03 21:57:43 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/ufs/ffs ffs_alloc.c=20 +> Log: +> Initialize the inode i_flag field in ffs_valloc() to clean up any +> stale flag bits left over from before the inode was recycled. +> =20 +> Without this change, a leftover IN_SPACECOUNTED flag could prevent +> softdep_freefile() and softdep_releasefile() from incrementing +> fs_pendinginodes. Because handle_workitem_freefile() unconditionally +> decrements fs_pendinginodes, a negative value could be reported at +> file system unmount time with a message like: +> unmount pending error: blocks 0 files -3 +> The pending block count in fs_pendingblocks could also be negative +> for similar reasons. These errors can cause the data returned by +> statfs() to be slightly incorrect. Some other cleanup code in +> softdep_releasefile() could also be incorrectly bypassed. Not sure how much the problem I'm seeing is related to this, but after clean reboot, when I do: # mount -u -r /usr I get: /usr: update error: blocks 24 files 1 Any idea what's going on? This file system is using soft-updates. Maybe it remounts itself to read-only before flushing buffers? Not sure how old is the problem, but could be very old. Before GEOM device was always open RW, now RO means RO and the order could be wrong somewhere. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --6WlEvdN9Dv0WHSBl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDYHnyForvXbEpPzQRAnyEAKCwpqvvx+cBqYzuvcDNnfd3IX28DACglW2x qFdpCZ6P/wBRWwhtbsFrB/A= =sCfu -----END PGP SIGNATURE----- --6WlEvdN9Dv0WHSBl--