From owner-freebsd-rc@FreeBSD.ORG Thu Aug 6 21:44:40 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2321D106564A for ; Thu, 6 Aug 2009 21:44:40 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id AB1238FC17 for ; Thu, 6 Aug 2009 21:44:39 +0000 (UTC) Received: (qmail 26617 invoked by uid 399); 6 Aug 2009 21:17:53 -0000 Received: from localhost (HELO ?192.168.0.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 6 Aug 2009 21:17:53 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A7B487B.8060303@FreeBSD.org> Date: Thu, 06 Aug 2009 14:17:47 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: d@delphij.net References: <4A7B2792.4090803@delphij.net> In-Reply-To: <4A7B2792.4090803@delphij.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: [RFC] script for binding ARP <-> IP pairs X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2009 21:44:40 -0000 Xin LI wrote: > Hi, > > Here is a new rc.d startup script, which helps to bind static ARP > entries like this: > > static_arp_pairs="gw" > arp_gw="172.16.1.254 00:1c:58:6a:7a:4c" > > At the beginning I was inclined to add an "options" part for this script > which helps to set e.g. logging options for ARP but it looks that these > would be redundant, i.e., can be done with easy /etc/sysctl.conf. > > Comments? This looks pretty good. My only suggestion would be to change the file name, $name and PROVIDE to static_arp (and then in your example above the second var would be static_arp_gw). I realize that currently we have a non-trivial number of legacy variables that don't match their related script names and/or $name, however going forward my preference would be that we not add any more examples of this. I also think it's a bit more descriptive of what you're doing in the script. hth, Doug