From owner-freebsd-current@FreeBSD.ORG Tue Jul 1 06:02:38 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB120942 for ; Tue, 1 Jul 2014 06:02:38 +0000 (UTC) Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F2FA2780 for ; Tue, 1 Jul 2014 06:02:37 +0000 (UTC) Received: by mail-ie0-f172.google.com with SMTP id lx4so7777848iec.3 for ; Mon, 30 Jun 2014 23:02:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=ucGI5wK1+nMVXTzlsRiE3YpAaylQuedlLZDFdtATziE=; b=HSo8PW92M3YdAeRG19+0jDFw1b7mk7guHo/H84kX0jtL3yxMZh00qSALcv85mH5aDD 4rK6SKDB73B353bKf4kJo1hrmkh/n1XCfG2emwyzBNnNavQcKz3KYnkEqr6D3nGJWINb DNGvI+nyZJlcWvOZDk8GL1YVOsJ+6euXaHM65Zm32TAOZqoz2mFmmYEKKrD9PE+jwbP7 JHpM03dKFlqf+nGddy9tnlIoukJOiz9Y00BtBoqeU5lPKkOIv6SaR8WKPgQNF4+K5BAf rpCFebso2xIfzn0r0faSfG8wETlnDL6eICQaVCUAdO55Eg40gDbhPeK1UmTKLSWvw3Zs 0YBw== X-Gm-Message-State: ALoCoQmd7s1AAX3r9RAK5GzHku5GlveEVgUiwlNouMz50ERIUQoiyAqBibmsJoXUUeTGBbFrhktkbikZBEpxvsS3DB9e7X+RRqbZehjrCq9tKUILYZ9Iceo= X-Received: by 10.50.12.38 with SMTP id v6mr37310628igb.29.1404194551178; Mon, 30 Jun 2014 23:02:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.43.69.131 with HTTP; Mon, 30 Jun 2014 23:02:15 -0700 (PDT) In-Reply-To: <53B24820.2020800@selasky.org> References: <53A90116.7040306@selasky.org> <53A907E9.5020007@selasky.org> <53A9C37A.7030803@selasky.org> <53AA5A0E.1050704@selasky.org> <53AC8C21.6080504@selasky.org> <53AD01C6.1080005@selasky.org> <53AED789.9070504@selasky.org> <53B0E3FD.30800@selasky.org> <53B24820.2020800@selasky.org> From: "Lundberg, Johannes" Date: Tue, 1 Jul 2014 15:02:15 +0900 Message-ID: Subject: Re: ucom_free Fatal trap on shutdown / module unload To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: FreeBSD Current , Fredrik Lindberg X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2014 06:02:38 -0000 SGkgSGFucw0KDQpUaGFua3MgZm9yIHRoZSB1aHNvIHBhdGNoLiBUaGF0IGRpZCB0aGUgdHJpY2su IE5vdyByZWJvb3QgYW5kIGtsZHVubG9hZA0Kd29ya3MgZmluZS4NCg0KLS0NCkpvaGFubmVzIEx1 bmRiZXJnDQpCUklMTElBTlRTRVJWSUNFIENPLiwgTFRELg0KDQoNCk9uIFR1ZSwgSnVsIDEsIDIw MTQgYXQgMjozMyBQTSwgSGFucyBQZXR0ZXIgU2VsYXNreSA8aHBzQHNlbGFza3kub3JnPiB3cm90 ZToNCg0KPiBIaSwNCj4NCj4gVHJ5IHRoZSBhdHRhY2hlZCBwYXRjaC4gRG9lcyBpdCBtYWtlIGFu eSBkaWZmZXJlbmNlPw0KPg0KPiAtLUhQUw0KPg0KCi0tIAo9LT0tPS09LT0tPS09LT0tPS09LT0t PS09LT0tPS09LT0tPS09LT0tPS09LT0tPS09LT0tPS0K56eY5a+G5L+d5oyB44Gr44Gk44GE44Gm 77ya44GT44Gu6Zu75a2Q44Oh44O844Or44Gv44CB5ZCN5a6b5Lq644Gr6YCB5L+h44GX44Gf44KC 44Gu44Gn44GC44KK44CB56eY5Yy/54m55qip44Gu5a++6LGh44Go44Gq44KL5oOF5aCx44KS5ZCr 44KT44Gn44GE44G+44GZ44CCCuOCguOBl+OAgeWQjeWum+S6uuS7peWkluOBruaWueOBjOWPl+S/ oeOBleOCjOOBn+WgtOWQiOOAgeOBk+OBruODoeODvOODq+OBruegtOajhOOAgeOBiuOCiOOBs+OB k+OBruODoeODvOODq+OBq+mWouOBmeOCi+S4gOWIh+OBrumWi+ekuuOAgQropIflhpnjgIHphY3l uIPjgIHjgZ3jga7ku5bjga7liKnnlKjjgIHjgb7jgZ/jga/oqJjovInlhoXlrrnjgavln7rjgaXj gY/jgYTjgYvjgarjgovooYzli5XjgoLjgZXjgozjgarjgYTjgojjgYbjgYrpoZjjgYTnlLPjgZfk uIrjgZLjgb7jgZnjgIIKLS0tCkNPTkZJREVOVElBTElUWSBOT1RFOiBUaGUgaW5mb3JtYXRpb24g aW4gdGhpcyBlbWFpbCBpcyBjb25maWRlbnRpYWwKYW5kIGludGVuZGVkIHNvbGVseSBmb3IgdGhl IGFkZHJlc3NlZS4KRGlzY2xvc3VyZSwgY29weWluZywgZGlzdHJpYnV0aW9uIG9yIGFueSBvdGhl ciBhY3Rpb24gb2YgdXNlIG9mIHRoaXMKZW1haWwgYnkgcGVyc29uIG90aGVyIHRoYW4gaW50ZW5k ZWQgcmVjaXBpZW50LCBpcyBwcm9oaWJpdGVkLgpJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQg cmVjaXBpZW50IGFuZCBoYXZlIHJlY2VpdmVkIHRoaXMgZW1haWwgaW4KZXJyb3IsIHBsZWFzZSBk ZXN0cm95IHRoZSBvcmlnaW5hbCBtZXNzYWdlLgo= From owner-freebsd-current@FreeBSD.ORG Tue Jul 1 05:33:07 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2DA1683 for ; Tue, 1 Jul 2014 05:33:07 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 93E022556 for ; Tue, 1 Jul 2014 05:33:06 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A6B0F1FE02D; Tue, 1 Jul 2014 07:33:03 +0200 (CEST) Message-ID: <53B24820.2020800@selasky.org> Date: Tue, 01 Jul 2014 07:33:20 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: "Lundberg, Johannes" Subject: Re: ucom_free Fatal trap on shutdown / module unload References: <53A90116.7040306@selasky.org> <53A907E9.5020007@selasky.org> <53A9C37A.7030803@selasky.org> <53AA5A0E.1050704@selasky.org> <53AC8C21.6080504@selasky.org> <53AD01C6.1080005@selasky.org> <53AED789.9070504@selasky.org> <53B0E3FD.30800@selasky.org> In-Reply-To: Content-Type: multipart/mixed; boundary="------------030502030109090002050804" Cc: FreeBSD Current , Fredrik Lindberg X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2014 05:33:08 -0000 This is a multi-part message in MIME format. --------------030502030109090002050804 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Try the attached patch. Does it make any difference? --HPS --------------030502030109090002050804 Content-Type: text/x-patch; name="uhso.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="uhso.diff" === uhso.c ================================================================== --- uhso.c (revision 268059) +++ uhso.c (local) @@ -559,8 +559,6 @@ mtx_init(&sc->sc_mtx, "uhso", NULL, MTX_DEF); ucom_ref(&sc->sc_super_ucom); - sc->sc_ucom = NULL; - sc->sc_ttys = 0; sc->sc_radio = 1; id = usbd_get_interface_descriptor(uaa->iface); @@ -680,9 +678,6 @@ UHSO_CTRL_MAX); } } - - free(sc->sc_tty, M_USBDEV); - free(sc->sc_ucom, M_USBDEV); } if (sc->sc_ifp != NULL) { @@ -710,6 +705,8 @@ uhso_free_softc(struct uhso_softc *sc) { if (ucom_unref(&sc->sc_super_ucom)) { + free(sc->sc_tty, M_USBDEV); + free(sc->sc_ucom, M_USBDEV); mtx_destroy(&sc->sc_mtx); device_free_softc(sc); } --------------030502030109090002050804--