From nobody Thu Jun 12 04:48:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHqmM15Zkz5y66K; Thu, 12 Jun 2025 04:48:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHqmL67vZz3R57; Thu, 12 Jun 2025 04:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749703714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RC3Mg6qz1U0VCPSJj1PzQwEipg1LfTllvAviDUwrH/I=; b=P6fSOKOXl5Wru5zo0vZM9HLW8f4EFuGECgH5P1jHNbzqtZ4PlpzNsLOVchGriDeFf5zo+H M77nYKsNXcS38XtJ277b7eDUCJJF5O8fTScKLM/j9i+m9gYn7IaNXAPAOV5nWpaugtLAqs 0BVRWkatudNdIjaT5sJAKws568kHwVsGGg2mPPPlHse9w45OJUvx8VvQnLHOM3lY44/YJ3 N5aCFKrTUFX4Cf9aUkTwyYK11F0nF9lc116geGCVBADV6sFmxGNTM7FAj325cQdtLyqIhr +alk96XLUhBhUu+ILiyGgUVbYwu5qe3VbHnfZIVGZgiuKM7df335HXx8mYhYCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749703714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RC3Mg6qz1U0VCPSJj1PzQwEipg1LfTllvAviDUwrH/I=; b=tWAF2s67QGf3rGHmhBi+UmLSE1argfU0eK4shGUNei1DOhXW+4iKWHAxsIBOhJ0uHiQcfo o0sX2JnCBs3OzGJnwSoUvD9qawrI+VoCCEFGnzhLy0mDHBa7Xg6WBIN49lbLw8R4sEB7sO ACw3KMurUIuvOcCjl1+M2CHFBu9g40nKX1lVGRksm9Cd2Oncvkuq+1Lxgfc1RCuVLDHeUf opfrjVQuz7ckoKJpk34v2v2DQym3sizOuL4e2HobWvmUPHexXX1+PTK7JsBoh9R1/kvew5 1z2mt/zp7wcDi/qNb0h1j3kIDGgss2ye8ZxGtkcRsUVZpoX9hVaH6Y2Np//rdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749703714; a=rsa-sha256; cv=none; b=qTF07gosf2R2bkk+iq9ksj0ZNDKY3TTSp3tcmXcs7W/hXB9MM15Vrcfajp3ToIWFGNrBdt gpdxiI648VGbjRL9kolqOCt6/xmhBs561pot9yOMGNILFL0Xtzz9AbjDAm1SZEo54KdRMH Y6CcICJmdddW4gd4QOHI/7CVRPapZbFlcilKOrSlPaS7lflZJ/yYd90FsEpA/13bi4P3it /lr22fc/Z0/x2dviY3e0td7rDAUsFM6+I235S741fZJJLqZMViamswP/QI6UmIIRaq+c0k 1YYWPWA7Et56K7RsQspMxhQrPnf5lNK7bENdC2/eMSb30YpWiaL1WgT6K+h2TA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bHqmL5Wfczxkw; Thu, 12 Jun 2025 04:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55C4mYcq066591; Thu, 12 Jun 2025 04:48:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55C4mYPh066588; Thu, 12 Jun 2025 04:48:34 GMT (envelope-from git) Date: Thu, 12 Jun 2025 04:48:34 GMT Message-Id: <202506120448.55C4mYPh066588@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 0c071c3ebdf1 - stable/14 - ktrace: trace and decode thr_new() thr_param List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0c071c3ebdf12438fd880fa81a7fd5c93130c59d Auto-Submitted: auto-generated The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=0c071c3ebdf12438fd880fa81a7fd5c93130c59d commit 0c071c3ebdf12438fd880fa81a7fd5c93130c59d Author: Konstantin Belousov AuthorDate: 2025-06-04 05:41:47 +0000 Commit: Konstantin Belousov CommitDate: 2025-06-12 04:28:26 +0000 ktrace: trace and decode thr_new() thr_param Sponsored by: The FreeBSD Foundation MFC after: 1 week (cherry picked from commit 56a4d1a4cc151cf8356704aafd2d2ec0fd009701) --- sys/kern/kern_thr.c | 8 ++++++++ sys/sys/ktrace.h | 2 ++ usr.bin/kdump/kdump.c | 21 +++++++++++++++++++++ 3 files changed, 31 insertions(+) diff --git a/sys/kern/kern_thr.c b/sys/kern/kern_thr.c index 0ab4cb5f7970..7c6d00692009 100644 --- a/sys/kern/kern_thr.c +++ b/sys/kern/kern_thr.c @@ -26,11 +26,15 @@ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "opt_ktrace.h" #include "opt_posix.h" #include "opt_hwpmc_hooks.h" #include #include +#ifdef KTRACE +#include +#endif #include #include #include @@ -185,6 +189,10 @@ kern_thr_new(struct thread *td, struct thr_param *param) return (error); rtpp = &rtp; } +#ifdef KTRACE + if (KTRPOINT(td, KTR_STRUCT)) + ktrthrparam(param); +#endif return (thread_create(td, rtpp, thr_new_initthr, param)); } diff --git a/sys/sys/ktrace.h b/sys/sys/ktrace.h index b615d82d2198..f86a9bb807d3 100644 --- a/sys/sys/ktrace.h +++ b/sys/sys/ktrace.h @@ -350,6 +350,8 @@ void ktrcapfail(enum ktr_cap_violation, const void *); ktrstruct("cpuset_t", (s), l) #define ktrsplice(s) \ ktrstruct("splice", (s), sizeof(struct splice)) +#define ktrthrparam(s) \ + ktrstruct("thrparam", (s), sizeof(struct thr_param)) extern u_int ktr_geniosize; #ifdef KTRACE extern int ktr_filesize_limit_signal; diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c index bde4eb7657e0..3240773f357b 100644 --- a/usr.bin/kdump/kdump.c +++ b/usr.bin/kdump/kdump.c @@ -62,6 +62,7 @@ static char sccsid[] = "@(#)kdump.c 8.1 (Berkeley) 6/6/93"; #include #include #include +#include #include #include #include @@ -120,6 +121,7 @@ void ktrsockaddr(struct sockaddr *); void ktrsplice(struct splice *); void ktrstat(struct stat *); void ktrstruct(char *, size_t); +void ktrthrparam(struct thr_param *); void ktrcapfail(struct ktr_cap_fail *); void ktrfault(struct ktr_fault *); void ktrfaultend(struct ktr_faultend *); @@ -1944,6 +1946,18 @@ ktrsplice(struct splice *sp) (intmax_t)sp->sp_idle.tv_usec); } +void +ktrthrparam(struct thr_param *tp) +{ + printf("thr param { start=%p arg=%p stack_base=%p " + "stack_size=%#zx tls_base=%p tls_size=%#zx child_tidp=%p " + "parent_tidp=%p flags=", + tp->start_func, tp->arg, tp->stack_base, tp->stack_size, + tp->tls_base, tp->tls_size, tp->child_tid, tp->parent_tid); + print_mask_arg(sysdecode_thr_create_flags, tp->flags); + printf(" rtp=%p }\n", tp->rtp); +} + void ktrstat(struct stat *statp) { @@ -2139,6 +2153,13 @@ ktrstruct(char *buf, size_t buflen) goto invalid; memcpy(&sp, data, datalen); ktrsplice(&sp); + } else if (strcmp(name, "thrparam") == 0) { + struct thr_param tp; + + if (datalen != sizeof(tp)) + goto invalid; + memcpy(&tp, data, datalen); + ktrthrparam(&tp); } else { #ifdef SYSDECODE_HAVE_LINUX if (ktrstruct_linux(name, data, datalen) == false)