From owner-cvs-all Sun Dec 13 15:47:27 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA26868 for cvs-all-outgoing; Sun, 13 Dec 1998 15:47:27 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from mrelay.jrc.it (mrelay.jrc.it [139.191.1.65]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA26856; Sun, 13 Dec 1998 15:47:13 -0800 (PST) (envelope-from nick.hibma@jrc.it) Received: from heidi.plazza.it (mobile18.jrc.it [139.191.250.18]) by mrelay.jrc.it (LMC5692) with SMTP id AAA02968; Mon, 14 Dec 1998 00:47:30 +0100 (MET) Date: Mon, 14 Dec 1998 00:48:27 +0100 (CET) From: Nick Hibma X-Sender: n_hibma@heidi.plazza.it Reply-To: Nick Hibma To: Garrett Wollman cc: "Justin T. Gibbs" , Julian Elischer , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ohci.c In-Reply-To: <199812121945.OAA05272@khavrinen.lcs.mit.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > >> This fixes the symptom and not the cause. > >> The right answer is to let the PCI system know that the attach failed, > >> or to fail earlier (in the PCI probe). > >> The attach() is a void fn() so it can't return failure.. > > > pci_unmap_int should also be implemented. > > It's called BUS_TEARDOWN_INTR(). I don't think that that takes care of the PCI interrupt itself. It's only a framework from what I can see. ./compile/USB/bus_if.h:bus_teardown_intr_t BUS_TEARDOWN_INTR; ./compile/USB/bus_if.c:int BUS_TEARDOWN_INTR(device_t dev, device_t child, struct resource *irq, ./kern/subr_bus.c: return (BUS_TEARDOWN_INTR(dev->parent, dev, irq, cookie)); Cheers, Nick -- e-Mail: n_hibma@etla.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message