Date: Fri, 28 Feb 2003 13:00:13 +0200 From: Justas Gurinavicius <raktas@raktas.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: raktas@raktas.net Subject: ports/48771: Bug in audio/shout when using with SHOUTcast Server 1.9.2 Message-ID: <5994981255.20030228130013@raktas.net>
next in thread | raw e-mail | index | archive | help
>Number: 48771 >Category: ports >Synopsis: Bug in audio/shout when using with SHOUTcast Server 1.9.2 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Feb 28 03:10:08 PST 2003 >Closed-Date: >Last-Modified: >Originator: Justas Gurinavicius >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: >Description: Shout is streaming client for icecast and shoutcast streaming servers. It works well with SHOUTcast Server Version 1.9.2/FreeBSD4 (with -i key (Use old icy headers)),But if you try to enable title streaming (-t key) (without it clients don't see what song is playing). There are two problems why it doesn't work: 1. By default shoutcast expects source stremer connection on 8001 port, and listeners on 8000 port. (steamer port is listener_port+1). Shout streams mp3 music on port 8001 (from config file or command line), but title streaming is done on listener port through web admin interface. (http://server:port//admin.cgi?pass=password&mode=updinfo&song=Song Title) Without patch shout tries to update info on streamer, and not listener port and this doesn't work. I attached patch which reduces port number by one, which is right (listener) port number. 2. With this fix shout connects to right port, but still doesn't update song title. From shoutcast documentation I've found that now shoutcast accepts update post (see above) only with useragent Mozilla ant shout gives useragent Shout/0.8.0. Allso a link to shout source is broken. I provided own link: http://www.raktas.net/~justas/shout/shout-0.8.0.tar.gz Please add it to MASTER_SITES. >How-To-Repeat: Install SHOUTcast Server Version 1.9.2/FreeBSD4 server ant shout-0.8.0. Use port 8001 to connect for mp3 streaming, use key -i (without it shout runs in icecast mode), and -t key for title streaming. Titles will note be updated without a patch. >Fix: For broken link: http://www.raktas.net/~justas/shout/shout-0.8.0.tar.gz Attached below. --- shout.diff begins here --- --- shout-0.8.0.orig/shout.c Thu Apr 20 09:31:50 2000 +++ shout-0.8.0/shout.c Thu Feb 27 15:47:37 2003 @@ -1738,7 +1738,7 @@ void update_meta_info_on_server (char *filename, unsigned long int size) { - sock_t sockfd = sock_connect (set.servername, set.port); + sock_t sockfd = sock_connect (set.servername, set.port-1); char title[BUFSIZE]; /* copy of filename */ char *song = NULL; char *mount = NULL; @@ -1815,7 +1815,7 @@ if (sockfd != -1) { if (set.use_icy) { - sock_write (sockfd, "GET /admin.cgi?pass=%s&mode=updinfo&song=%s HTTP/1.0\nHost: %s:%d\nUser-Agent: Shout/%s\n\n", set.password, url_encode (titleptr, &song), set.servername, set.port, VERSION); + sock_write (sockfd, "GET /admin.cgi?pass=%s&mode=updinfo&song=%s HTTP/1.0\nHost: %s:%d\nUser-Agent: Mozilla(Shout/%s)\n\n", set.password, url_encode (titleptr, &song), set.servername, set.port-1, VERSION); } else { sock_write (sockfd, "GET /admin.cgi?pass=%s&mode=updinfo&mount=%s&song=%s&length=%ld HTTP/1.0\nHost: %s:%d\nUser-Agent: Shout/%s\n\n", set.password, url_encode (set.mount_name, &mount), url_encode (titleptr, &song), size, set.servername, set.port, VERSION); if (mount) --- shout.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: >System: FreeBSD somehost 4.7-STABLE FreeBSD 4.7-STABLE #0: Wed Jan 29 02:46:55 EET 2003 raktas@somehost:/usr/obj/usr/src/sys/FAILAI i386 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5994981255.20030228130013>