From owner-svn-src-all@freebsd.org Wed Dec 21 02:12:25 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5109C89E9A for ; Wed, 21 Dec 2016 02:12:25 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9908012D5 for ; Wed, 21 Dec 2016 02:12:25 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by mail-it0-x236.google.com with SMTP id o141so18984635itc.0 for ; Tue, 20 Dec 2016 18:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clockworksquid.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=82K8fiaYkfmqSWDt1wPSfWUcR2qffhzv1V1BbUGAOc4=; b=ayjBEtO7VheY4uQBvQ+m/4/i/+PqKePBI0Cbntw4RMOQaf9ogZdt9mITA3iXscedav ShJpnWrRdeK6OVqkkN4oasnLy24SPYPZQ3vXeTBnYV1utu3S75o0uJ+4MQ6jOLvZngSr EvcO79Iwg4J0tu4Z8ef3OxHZzZkFERHtww/4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=82K8fiaYkfmqSWDt1wPSfWUcR2qffhzv1V1BbUGAOc4=; b=pLyqgXu/byMroAD/Q2YbYRzWNfmthldROTJj0u+Srx4kcgyh3MPiFgHYcVqMQCw88j GgcAX+DnhxW94Mnbl8++Xv89Yet/WhMKBkqY71BbTbnO4+QGemezEKKBrCHKIYAbbNZ7 LYCJya+WdEUb8MZuBHdkct6uC63mtzeTkpbFbNWZGP3wrSeQkcXam+g6R+vDO2QujcCC zAOog0zAu5/0etOYatkMig7csqxUTL98w0Pm5yJ5rDxEYSiP/qadeVHWPnWmdeDi8qE8 4X/wnsPmfw27gHksvyl/CSqr+Qy/hmfI1OR49hQoqwt/wSVvKk/4dqQ+Yhp1DQHNJcUm cL+w== X-Gm-Message-State: AIkVDXIs9iPy7HguirCOXFspIuuYQq9LyQBQmlFZOEiQ5N+vzNn0/PmMG3pHlJkVnlkP24iqV5miDLUz0iBnMg== X-Received: by 10.36.249.203 with SMTP id l194mr5460477ith.19.1482286344921; Tue, 20 Dec 2016 18:12:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.50.210 with HTTP; Tue, 20 Dec 2016 18:12:04 -0800 (PST) In-Reply-To: References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <49460793.UcUNovQMDa@ralph.baldwin.cx> <1482281779.48539.41.camel@freebsd.org> From: Juli Mallett Date: Tue, 20 Dec 2016 18:12:04 -0800 Message-ID: Subject: Re: svn commit: r310138 - head/lib/libc/stdio To: Conrad Meyer Cc: Adrian Chadd , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 02:12:25 -0000 On Tue, Dec 20, 2016 at 6:04 PM, Conrad Meyer wrote: > Hi Adrian, > > On Tue, Dec 20, 2016 at 5:56 PM, Adrian Chadd wrote: >> Here's my reason for removal. >> >> Plenty of us are looking to be able to build bits of the BSD source >> tree as part of other non FreeBSD systems, especially if they're >> involved in bootstrapping. > > Understood, however: > >> That means that it needs to be compilable >> by a non-FreeBSD-modified compiler. Ideally this means we'd stick to >> mostly POSIX options source code that we can compile with unmodified >> compilers, and we push non-standard stuff into otherly-named >> functions. > > Yeah, this isn't actually a problem. printf("%b", foo) compiles fine > with non-modified compilers. I want FreeBSD tools to avoid non-standard extensions to standard APIs where possible. Non-standard APIs are fine, because they're easy to provide one's own implementations along with portable software, but building in quirky behaviour to core POSIX/C/whatever interfaces invites pain. In this case, the cost-benefit ratio is all out of whack. Now, %b is unusual enough that I don't have to worry that, say, a bootstrap tool will use it, but it's also unusual enough that the benefit here is elusive. I would love to see this reverted and snprintb instead.