From owner-freebsd-geom@freebsd.org Tue Jul 14 06:42:21 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 488C299C522 for ; Tue, 14 Jul 2015 06:42:21 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 20D991C0; Tue, 14 Jul 2015 06:42:20 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id C61E737B4A0; Tue, 14 Jul 2015 01:42:12 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mVshh0p87z1bX; Tue, 14 Jul 2015 01:42:12 -0500 (CDT) Date: Tue, 14 Jul 2015 01:42:12 -0500 From: "Matthew D. Fuller" To: Pawel Jakub Dawidek Cc: RW , freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150714064212.GZ96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> <20150710222837.GE96394@over-yonder.net> <20150711141553.3fcf91f4@gumby.homeunix.com> <20150713153146.GA1984@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150713153146.GA1984@garage.freebsd.pl> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 06:42:21 -0000 On Mon, Jul 13, 2015 at 05:31:46PM +0200 I heard the voice of Pawel Jakub Dawidek, and lo! it spake thus: > > So what do you guys think about implementing trim support this way: > > geli -d > > 'overwrite' may be implemented later and 'trim' would be the default? Well, if you ask me, we can work out the UI for a 3-way choice when a third way is implemented. Doing shredding would presumably be noted by adding another flag[0] for it anyway, so doing it on top of this patch oughtn't take it out of its way. Nobody's implemented it in the last 10 years that there's been a comment suggesting it. So, from my selfish perspective, I'd as soon land this as a solid step forward, and worry about a shredding implementation when one gets written... [0] I mean, I _guess_ we could add another element into the metadata/softc structs just to hold a 3-way 'delete handling' option, but that sounds way heavier-weight than necessary. Also would need new geli version and blah. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.