From owner-svn-src-head@FreeBSD.ORG Sat Feb 28 15:01:58 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 20E7A491; Sat, 28 Feb 2015 15:01:58 +0000 (UTC) Received: from mail-pd0-x230.google.com (mail-pd0-x230.google.com [IPv6:2607:f8b0:400e:c02::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA2C7EBC; Sat, 28 Feb 2015 15:01:57 +0000 (UTC) Received: by pdev10 with SMTP id v10so28061280pde.7; Sat, 28 Feb 2015 07:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=dAA27z/2QgurqRrfNQHlNJ0ZT5oc4qMksMEI5w9/ESQ=; b=oMsdxNldaXL8E8jzHfHuCZoIf1C8bCUAzcwTzJEHGiqAadBuuNSiB13Xh/HQNAREsA YS3E9Nl+/4bvrk1+F+YRBWL9nhXpm9uk5Rwb2Mp1MEeuzFLa/bGlVsx5dly9FiSRlREk 1qkfGcBEwovPs2Zja+JI2EQrIU/vbIAspyTc7IILc4uAwjaRjMLs3QMc6P3MrBnBD2GL KGCu18pHW5iRsVYXn/sJQS07Bb0ITz79cQX8+5t6622WJjEEoNAm4bbsl5c2O4X5tYAl gBUlSlDJ2i+gXnPb/hrw4awBlq+7EgXaZihGIfUoi3uLfItyzD2sbty2PTqRz87Paxul 5j+g== X-Received: by 10.66.65.138 with SMTP id x10mr32296461pas.152.1425135717416; Sat, 28 Feb 2015 07:01:57 -0800 (PST) Received: from [192.168.20.5] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id lg8sm7028445pbc.55.2015.02.28.07.01.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 28 Feb 2015 07:01:55 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_A96FFEE6-C58A-4FCD-9114-74EC5C465C45"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r279393 - head/sys/dev/ixgbe From: Garrett Cooper In-Reply-To: <201502281457.t1SEvv4Y009907@svn.freebsd.org> Date: Sat, 28 Feb 2015 07:01:54 -0800 Message-Id: <3587EFB4-728C-475D-BC8B-3AFD98B5635B@gmail.com> References: <201502281457.t1SEvv4Y009907@svn.freebsd.org> To: Garrett Cooper X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, Jack F Vogel , svn-src-all@freebsd.org, src-committers , erj@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2015 15:01:58 -0000 --Apple-Mail=_A96FFEE6-C58A-4FCD-9114-74EC5C465C45 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Feb 28, 2015, at 6:57, Garrett Cooper wrote: > Author: ngie > Date: Sat Feb 28 14:57:57 2015 > New Revision: 279393 > URL: https://svnweb.freebsd.org/changeset/base/279393 >=20 > Log: > Pad RX copy alignment calculation to avoid illegal memory accesses >=20 > The optimization made in r239940 is valid for struct mbuf's current = structure > and size in FreeBSD, but hardcodes assumptions about sizes of struct = mbuf, > which are unfortunately broken if additional data is added to the = beginning of > struct mbuf >=20 > X-MFC note (discussed with rwatson): >=20 > This change requires the MPKTHSIZE definition, which is only = available after > head@r277203 and will not be MFCed as it breaks mbuf(9) KPI. >=20 > A direct commit to stable/10 and merges to other branches to add the = necessary > definitions to work with the code as-is will be done to facilitate = this MFC >=20 > PR: 194314 > MFC after: 2 weeks > Approved/Reviewed by: erj, jfv > Sponsored by: EMC / Isilon Storage Division I forgot to note that the fix was submitted by erj in the PR. I=92ll fix = that in the MFC message. Thank you very much for the help Eric and Jack! --Apple-Mail=_A96FFEE6-C58A-4FCD-9114-74EC5C465C45 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU8dhiAAoJEMZr5QU6S73eCAgIAID3DQA9r9I1dwAglhSXMoPf QNft5WQxlB5InWequxEFdsceRl1ylvFb7NiBbAZvR16oYmnSSupFyiSBya84Z+D8 ssYcsx4KABw92HcYvrQjV8oi0D16W3vKLI0oTE2gDPEbsT+sV6wRafXEYBvXydYi bRUVyeiTkBWU+KLxttXDrxkY8O33st6PdjWbiqG12IRRB7/mNfT5IYDtnRBHCB7T h77Xgks+qwHiy7IfnTGqedmJGD4unAUUTgCwBKQuv8GeybKmAoOaJLajPZbEXQ3T cpnKG/WpuLh4WPpy4aKg1xwHvg7mjV1znL7qJCArlAk6VCJXut7h1duh+UvOG4k= =0WL/ -----END PGP SIGNATURE----- --Apple-Mail=_A96FFEE6-C58A-4FCD-9114-74EC5C465C45--