Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 May 2021 21:52:49 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        Guy Yur <guyyur@gmail.com>, "Alexander V. Chernikov" <melifaro@FreeBSD.org>, freebsd-net@freebsd.org
Subject:   Re: fib[46]_lookup_rt usage in netflow.c, sa_len comparison with AF_INET
Message-ID:  <072f455b-a0e6-54e6-41b0-5ae231a57031@selasky.org>
In-Reply-To: <fb48d063-b15d-3211-94e8-57c33367edaa@gmail.com>
References:  <fb48d063-b15d-3211-94e8-57c33367edaa@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5/18/21 5:46 PM, Guy Yur wrote:
> Hi,
> 
> I was looking for examples on how to use fib6_lookup_rt and noticed
> there are comparisons between sa_len and AF_ flags in netflow.c
> if (nh->gw_sa.sa_len == AF_INET)
> if (nh->gw_sa.sa_len == AF_INET6)
> 
> Are these typos for sa_family?

Hi,

According to:

sys/net/route/nhop.c

Yes. Should both be sa_family.

--HPS

> 
> https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n363
> https://cgit.freebsd.org/src/tree/sys/netgraph/netflow/netflow.c#n437
> 
> Added in 
> https://cgit.freebsd.org/src/commit/sys/netgraph/netflow/netflow.c?id=4e19e0d92ac6dfa5d2df6d525922f1e60487a9cc 

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?072f455b-a0e6-54e6-41b0-5ae231a57031>