Date: Sun, 11 Nov 2007 20:14:06 GMT From: Coleman Kane <cokane@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/117986: graphics/ImageMagick WITH_PERL PerlMagick test fails on t/filter.t with Despeckle filter Message-ID: <200711112014.lABKE6f0056504@www.freebsd.org> Resent-Message-ID: <200711112020.lABKK08D040469@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 117986
>Category: ports
>Synopsis: graphics/ImageMagick WITH_PERL PerlMagick test fails on t/filter.t with Despeckle filter
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 11 20:20:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Coleman Kane
>Release: 8.0-CURRENT
>Organization:
FreeBSD Project
>Environment:
FreeBSD erwin 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Nov 11 08:06:05 EST 2007 root@erwin:/usr/obj/usr/src/sys/ERWIN amd64
>Description:
When trying to install the latest ImageMagick, the PerlMagick test fails performing the t/filter.t test. After setting TEST_VERBOSE=1 in PerlMagick/Makefile, I traced this down to the Despeckle test in filter.t. This test has a defined max deviation limit value of 0.06, but on my system the max deviation when this test goes up to over 0.07. I changed this value to 0.08 and the test built fine after that. I am no ImageMagick whiz, so I am not sure what the ultimate ramification of this change is. I suspect that it means that the compiled Despeckle filter for the Perl module is not as effective as they would like it to be.
>How-To-Repeat:
Enable Perl support in ImageMagick port (6.3.6-9). Try to make install it, and it fails on the tests, preventing it from being installed.
>Fix:
Attaching a patch of what I did to fix this.
Patch attached with submission follows:
--- ImageMagick-6.3.6/PerlMagick/t/filter.t.orig 2007-11-11 15:01:48.000000000 -0500
+++ ImageMagick-6.3.6/PerlMagick/t/filter.t 2007-11-11 14:59:38.000000000 -0500
@@ -70,7 +70,7 @@
testFilterCompare('input.miff', q//, 'reference/filter/Set.miff', 'Set', q/page=>'0x0+0+0'/, 0.002, 0.02);
++$test;
-testFilterCompare('input.miff', q//, 'reference/filter/Despeckle.miff', 'Despeckle', q//, 0.002, 0.06);
+testFilterCompare('input.miff', q//, 'reference/filter/Despeckle.miff', 'Despeckle', q//, 0.002, 0.08);
++$test;
testFilterCompare('input.miff', q//, 'reference/filter/Draw.miff', 'Draw', q/fill=>'none',stroke=>'gold',primitive=>'circle',points=>'60,90 60,120',strokewidth=>2/, 0.002, 0.02);
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200711112014.lABKE6f0056504>