From owner-cvs-all  Sun Dec 26  4:11:41 1999
Delivered-To: cvs-all@freebsd.org
Received: from peach.ocn.ne.jp (peach.ocn.ne.jp [210.145.254.87])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0B4BB14E19; Sun, 26 Dec 1999 04:11:35 -0800 (PST)
	(envelope-from dcs@newsguy.com)
Received: from newsguy.com (p20-dn02kiryunisiki.gunma.ocn.ne.jp [210.163.200.117])
	by peach.ocn.ne.jp (8.9.1a/OCN) with ESMTP id VAA09200;
	Sun, 26 Dec 1999 21:11:09 +0900 (JST)
Message-ID: <38660523.74C8B37@newsguy.com>
Date: Sun, 26 Dec 1999 21:08:03 +0900
From: "Daniel C. Sobral" <dcs@newsguy.com>
X-Mailer: Mozilla 4.7 [en] (Win98; I)
X-Accept-Language: en,pt-BR,ja
MIME-Version: 1.0
To: Peter Wemm <peter@netplex.com.au>
Cc: Marcel Moolenaar <marcel@scc.nl>, Bruce Evans <bde@zeta.org.au>,
	Dag-Erling Smorgrav <des@flood.ping.uio.no>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src Makefile.inc1
References: <19991226093421.875B91CC6@overcee.netplex.com.au>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Peter Wemm wrote:
> 
> > That is not true. Just try making a file without -C containing a
> > "comment" and then fortune'ing it.
> 
> No problem, RELENG_2_2's strfile and fortune, *with* the ignore-comments patch
> but without -C:

[example failing to show the difference in a fortune *containing* a
comment skipped]

> -C is just a build inconvenience to make %% parsing optional.  We have
> enough options already without adding them for things that don't make sense
> to be an option.

-C is an option setting a flag in the dat file telling fortune to ignore
a specific type of line. Having it unconditional will make us
incompatible with other fortunes out there. 

> ie: it still works.  Even if it didn't, we don't need -C at 'make world'
> time because strfile does nothing special with the %% lines, and a new
> fortune(1) is installed at exactly the same time as the new datfiles.

-C makes something special with the files created by strfile. Setting a
flag.

Well, whatever. I think making it unconditional is an error, but I won't
make a bike shed out of it.

--
Daniel C. Sobral			(8-DCS)
dcs@newsguy.com
dcs@freebsd.org

		"Nice try, Lao Che."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message