From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 5 14:30:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B6A86E80 for ; Sat, 5 Apr 2014 14:30:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 931317D1 for ; Sat, 5 Apr 2014 14:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s35EU0iJ021711 for ; Sat, 5 Apr 2014 14:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s35EU0QX021708; Sat, 5 Apr 2014 14:30:00 GMT (envelope-from gnats) Resent-Date: Sat, 5 Apr 2014 14:30:00 GMT Resent-Message-Id: <201404051430.s35EU0QX021708@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pawel Pekala Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3DDBB548 for ; Sat, 5 Apr 2014 14:24:07 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2B003605 for ; Sat, 5 Apr 2014 14:24:07 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s35EO7L9037939 for ; Sat, 5 Apr 2014 14:24:07 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s35EO7ar037933; Sat, 5 Apr 2014 14:24:07 GMT (envelope-from nobody) Message-Id: <201404051424.s35EO7ar037933@cgiserv.freebsd.org> Date: Sat, 5 Apr 2014 14:24:07 GMT From: Pawel Pekala To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/188287: [PATCH] Mk/Uses/qmake.mk reset default qmake cflags settings X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2014 14:30:00 -0000 >Number: 188287 >Category: ports >Synopsis: [PATCH] Mk/Uses/qmake.mk reset default qmake cflags settings >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Apr 05 14:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Pawel Pekala >Release: 10.0 >Organization: >Environment: FreeBSD caprica.slowicza.org 10.0-STABLE FreeBSD 10.0-STABLE #2 r262297: Fri Feb 21 17:42:25 CET 2014 root@caprica.slowicza.org:/usr/obj/usr/src/sys/GENERIC i386 >Description: Qmake's default settings break our CFLAGS policy. In current state qmake adds cflags to our global ones. QMAKE_CFLAGS_RELEASE and QMAKE_CXXFLAGS_RELEASE are set to '-O2' by default So when our cflags is '-O2 -pipe -fno-strict-aliasing' after generating Makefile from pro file it is '-O2 -pipe -fno-strict-aliasing -O2' and our global cflags are tainted. QMAKE_CFLAGS_DEBUG and QMAKE_CXXFLAGS_DEBUG are set to '-g', but I think is good practice to reset them too. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: qmake.mk =================================================================== --- qmake.mk (wersja 350228) +++ qmake.mk (kopia robocza) @@ -61,6 +61,10 @@ QMAKE_CFLAGS="${CFLAGS}" \ QMAKE_CXXFLAGS="${CXXFLAGS}" \ QMAKE_LFLAGS="${LDFLAGS}" \ + QMAKE_CFLAGS_DEBUG="" \ + QMAKE_CFLAGS_RELEASE="" \ + QMAKE_CXXFLAGS_DEBUG="" \ + QMAKE_CXXFLAGS_RELEASE="" \ PREFIX="${PREFIX}" .if defined(WITH_DEBUG) >Release-Note: >Audit-Trail: >Unformatted: