From owner-cvs-all@FreeBSD.ORG  Wed Mar  9 19:37:33 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5E95616A4CE; Wed,  9 Mar 2005 19:37:33 +0000 (GMT)
Received: from saturn.criticalmagic.com (saturn.criticalmagic.com
	[64.74.124.105])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2ED8343D62; Wed,  9 Mar 2005 19:37:33 +0000 (GMT)
	(envelope-from rcoleman@criticalmagic.com)
Received: from [10.40.30.162] (delta.ciphertrust.com [216.235.158.34])
	by saturn.criticalmagic.com (Postfix) with ESMTP id 7928B3BD10;
	Wed,  9 Mar 2005 14:37:30 -0500 (EST)
Message-ID: <422F50A6.907@criticalmagic.com>
Date: Wed, 09 Mar 2005 14:38:14 -0500
From: Richard Coleman <rcoleman@criticalmagic.com>
Organization: Critical Magic
User-Agent: Mozilla Thunderbird 1.0 (X11/20041230)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Colin Percival <cperciva@FreeBSD.org>
References: <200503091923.j29JN4Ti063868@repoman.freebsd.org>
In-Reply-To: <200503091923.j29JN4Ti063868@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libmd Makefile sha256.3 sha256.h sha256c.c
 shadriver.c src/sbin/md5 Makefile md5.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2005 19:37:33 -0000

Colin Percival wrote:
> cperciva    2005-03-09 19:23:04 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libmd            Makefile shadriver.c 
>     sbin/md5             Makefile md5.c 
>   Added files:
>     lib/libmd            sha256.3 sha256.h sha256c.c 
>   Log:
>   In light of the recent 2^69 operation collision-finding attack on SHA1,
>   add support for SHA256.

Is there a reason that there are multiple versions of 
md5/sha1/sha256/etc in the source tree?  There are versions in at least 
three places (lib/libmd, sys/kern/crypto, and crypto/openssl/crypto).  I 
think md5 is located in a few other places as well.

It seems if these could be centralized, then it would be easier to have 
assembly accelerated versions for each platform, or better yet to 
utilize crypto hardware.

I was just curious.

Richard Coleman
rcoleman@criticalmagic.com