From owner-svn-src-all@freebsd.org Sat Oct 24 15:27:42 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0F05F44C34E for ; Sat, 24 Oct 2020 15:27:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CJQ2j2xGjz4g9g for ; Sat, 24 Oct 2020 15:27:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72a.google.com with SMTP id k9so4480017qki.6 for ; Sat, 24 Oct 2020 08:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SdeMX+1mHWz5ppQ2dcv5hUoGfnVrNWGKM7NYoewaOEY=; b=LrYuWVPi1JRw/yISuL3lDxSnd3nSLGVu7d7QqIbrNAGKloswNIzyVO2zHyq25+m25Q azJ1U7FGvKo6pl8eE99wrC70p3U1TgBnADYrFzO5T9zByRM9MzDV5v4qaINTdVrJpo3B IINJqVwunoIht1FORcD2UPVd3BGeuoKOcZQHxQC8sGh1kkILWAPwUAjp7TGyWvp3Q2Kd Ru85kMfo8WKtzOcAxe0eIuSOcX/BfoS/HV9v+POfNOCsPcczaHk49BKecUOXqMZywrJ2 92BtbsMJb9pycRj4EGDkFwtLkAP8AKQdN10LcKTkHENeoywIroFjMNhpM242yoxvMj5S Qnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SdeMX+1mHWz5ppQ2dcv5hUoGfnVrNWGKM7NYoewaOEY=; b=LygoiXgAgqIoyq9t+6hjILjw/wP8eJ+EDlrr5lMwfInLvC3m5z+EC+AS465zfutqkM m04KZepuylGeSjStq1K9Pni87HSB2wT50miKFqV3yiazrGpe6mfvwPo5UAQ8L7mhRpVZ Lm7V79R+X2qVKYmNFZCGFTUEX6M9q0ziuTrXoJkRLEyHbEExBjCt+pM+HsSDiO9f+GAe fZTk5lMWLezQj5BZDepmXsaWZVq69FWXtwsd+sa8OK2BczZb/3f3/gzmso902k8lAGhn 9u2tMR7/MZ9jRdhDvpBeV+xdfICWo64Bdun9xGzF5f5YHRgmDuajmtIWysEWVdiBiJzv W4Ow== X-Gm-Message-State: AOAM531w6sDErXav4bEZOSI++eEsmBFSms85IFvSXW7b5K8rATeB5ZTG 0z3guoHqE9acjmuEO6BcRBwh10iAfWNaUlraRKkAdg== X-Google-Smtp-Source: ABdhPJwvBRtz//IhRRsKPXkGlykwAVJakQ1j22LvQAgoSHyedgJS7kVnQXFAtQMUdVcM865doIXxsub+sHk0MXI1Mw8= X-Received: by 2002:a37:478c:: with SMTP id u134mr8438978qka.206.1603553259673; Sat, 24 Oct 2020 08:27:39 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> <317231603546378@mail.yandex.ru> In-Reply-To: <317231603546378@mail.yandex.ru> From: Warner Losh Date: Sat, 24 Oct 2020 09:27:27 -0600 Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: "Alexander V. Chernikov" Cc: Hans Petter Selasky , Alexey Dokuchaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 4CJQ2j2xGjz4g9g X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=LrYuWVPi; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.68 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.06)[-1.059]; NEURAL_HAM_LONG(-0.97)[-0.970]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.65)[-0.650]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72a:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-all]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 15:27:42 -0000 On Sat, Oct 24, 2020, 7:38 AM Alexander V. Chernikov wrote: > 24.10.2020, 14:08, "Hans Petter Selasky" : > > On 2020-10-24 14:52, Alexey Dokuchaev wrote: > >> On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote: > >>> New Revision: 366993 > >>> URL: https://svnweb.freebsd.org/changeset/base/366993 > >>> > >>> Log: > >>> Run code through "clang-format -style=file" with some additional > fixes. > >>> No functional change. > >>> > >>> ... > >>> @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr, > >>> > >>> #ifdef INET6 > >>> static inline void > >>> -infiniband_ipv6_multicast_map(const struct in6_addr *addr, > >>> - const uint8_t *broadcast, uint8_t *buf) > >>> +infiniband_ipv6_multicast_map( > >>> + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf) > >>> { > >> > >> This is not how we format these in FreeBSD, please revert. It was > correct > >> before and no "fix" is need here. > Given we already have nice .clang-format, that does most of the job, maybe > it's worth considering looking into tweaking it further to fix this part? > It would be nice if we could finally offload all formatting issues to the > tool and focus on the actual code :-) > It would be nice if it produced one of the style(9) acceptable formats without disrupting things already acceptable. That's been the big problem with the tweaks to date... some things are fixed, others break. It's getting a lot closer, though Warner > Done. > > > > --HPS >