Date: Sun, 16 Dec 2012 11:39:21 +1300 From: Andrew Turner <andrew@fubar.geek.nz> To: Garrett Cooper <yanegomi@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244278 - head/sys/boot/arm/uboot Message-ID: <20121216113921.0c9e2c9b@fubar.geek.nz> In-Reply-To: <ED62CF37-07A2-43D0-8985-79F6F577CD19@gmail.com> References: <201212152147.qBFLl6f1043013@svn.freebsd.org> <ED62CF37-07A2-43D0-8985-79F6F577CD19@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Dec 2012 13:57:02 -0800 Garrett Cooper <yanegomi@gmail.com> wrote: > On Dec 15, 2012, at 1:47 PM, Andrew Turner wrote: > > > Author: andrew > > Date: Sat Dec 15 21:47:05 2012 > > New Revision: 244278 > > URL: http://svnweb.freebsd.org/changeset/base/244278 > > > > Log: > > Ignore a warning in ubldr where clang doesn't understand the %D > > printf specifier from libstand. > > > > Modified: > > head/sys/boot/arm/uboot/Makefile > > > > Modified: head/sys/boot/arm/uboot/Makefile > > ============================================================================== > > --- head/sys/boot/arm/uboot/Makefile Sat Dec 15 21:33:12 > > 2012 (r244277) +++ head/sys/boot/arm/uboot/Makefile > > Sat Dec 15 21:47:05 2012 (r244278) @@ -109,6 +109,9 @@ > > CFLAGS+= -I${.OBJDIR}/../../uboot/lib # where to get > > libstand from CFLAGS+= -I${.CURDIR}/../../../../lib/libstand/ > > > > +# clang doesn't understand %D as a specifier to printf > > +NO_WERROR.clang= > > + > > DPADD= ${LIBFICL} ${LIBUBOOT} ${LIBFDT} ${LIBSTAND} > > LDADD= ${LIBFICL} ${LIBUBOOT} ${LIBFDT} -lstand > > Why not fix it similar to how I fixed libi386/pxe.c on my git > branch > ( https://github.com/yaneurabeya/freebsd/commit/709c2b0a47ec887f8df3a886d318c309a0659bf6 > )? Thanks, -Garrett > When you commit the sys/boot/common/dev_net.c change from that patch we should be able to revert this commit. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121216113921.0c9e2c9b>