From owner-freebsd-current@FreeBSD.ORG Thu Oct 18 17:45:18 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB3A616A46C for ; Thu, 18 Oct 2007 17:45:18 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id C257A13C46A for ; Thu, 18 Oct 2007 17:45:18 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id l9IHjFSd024981; Thu, 18 Oct 2007 10:45:15 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id l9IHj60H024974; Thu, 18 Oct 2007 10:45:06 -0700 (PDT) (envelope-from obrien) Date: Thu, 18 Oct 2007 10:45:06 -0700 From: "David O'Brien" To: Peter Jeremy Message-ID: <20071018174506.GB420@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, Peter Jeremy , Artem Kuchin , josh.carroll@gmail.com, Kostik Belousov , freebsd-current@freebsd.org, ??? Bill Hacker , Andrey Chernov References: <00bd01c810ec$10371230$0c00a8c0@Artem> <8cb6106e0710171143m3dff7546o457192ede76e6598@mail.gmail.com> <012c01c810f3$aafeecf0$0c00a8c0@Artem> <20071017193615.GO9006@server.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071017193615.GO9006@server.vk2pj.dyndns.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.16 (2007-06-09) Cc: josh.carroll@gmail.com, Andrey Chernov , ??? Bill Hacker , freebsd-current@freebsd.org, Kostik Belousov , Artem Kuchin Subject: Re: Broken su in current - trying to fix myself, help needed! X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 17:45:19 -0000 On Thu, Oct 18, 2007 at 05:36:15AM +1000, Peter Jeremy wrote: > This bug (or another one with identical symptoms) affects the 'su' > commands within the ports build system if you are using tcsh or zsh or bash It has been suggested that reverting rev 1.79 of su.c may address the issue. ---------------------------- revision 1.79 date: 2006/01/03 09:17:04; author: brian; state: Exp; lines: +14 -1 Fix the other su bug reintroduced two commits ago, namely $ su % kill -STOP $$ where su is executing (t)csh. csh's job handling is a little more special than that of (a)sh, bash and even zsh and blows up a little more spectacularly. This modification restores the original mucking about with the tty pgrp, but is careful to only do it when su (or su's child) is the foreground process ---------------------------- -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon? Let's not play "Jeopardy-style quoting"