Date: Wed, 23 Nov 2005 02:13:02 +0200 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: pav@FreeBSD.org Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/89300: [MAINTAINER] multimedia/bsdav: remove BROKEN Message-ID: <20051123021302.4f93a01d@it.buh.tecnik93.com> In-Reply-To: <1132704123.47320.21.camel@localhost> References: <200511222220.jAMMK1bB012364@freefall.freebsd.org> <20051123003447.7046be7d@it.buh.tecnik93.com> <1132699378.47320.12.camel@localhost> <20051123005108.14ffff2e@it.buh.tecnik93.com> <1132700575.47320.16.camel@localhost> <20051123014454.20ea3d62@it.buh.tecnik93.com> <1132704123.47320.21.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Nov 2005 01:02:03 +0100 Pav Lucistnik <pav@FreeBSD.org> wrote: > Ion-Mihai Tetcu p=C3=AD=C5=A1e v st 23. 11. 2005 v 01:44 +0200: >=20 > > > Third, you used OPTIONS incorrectly. I fixed that. For details, > > > see chapter in PH. > >=20 > > I see that: > > -.ifdef(WITH_X11) > > +.if !defined(WITHOUT_X11) > >=20 > > OK, if one does not what X it will put make.conf WITHOUT_X11=3D yes; > > so the port actually works (OPTIONS-wise) but one should use > > WITHOUT_X11 and this is said in PH. >=20 > No, that's not the reason.=20 Actually it's said to use WITHOUT_X11 but yes, the rest is more important. > Please read OPTIONS chapter in Porter's Handbook. It says, quote: >=20 > Due to a deficiency in the infrastructure, you can only test WITH_* > variables for options, which are OFF by default, and WITHOUT_* > variables for options, which defaults to ON. Read it, but on fast-forward :-/ It would be very nice if portlint(1) could catch this (AFAIK it check if either WITH_ or WITHOUT_ is defined for each OPTION). I think I should start checking my other ports. Thanks for spelling this to me. --=20 IOnut - Unregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" BOFH excuse #27: radiosity depletion
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051123021302.4f93a01d>