From owner-svn-src-head@freebsd.org Thu Jul 5 16:50:27 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F4235103CB58 for ; Thu, 5 Jul 2018 16:50:26 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yw0-x232.google.com (mail-yw0-x232.google.com [IPv6:2607:f8b0:4002:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F48E8889F for ; Thu, 5 Jul 2018 16:50:26 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yw0-x232.google.com with SMTP id c135-v6so3194035ywa.0 for ; Thu, 05 Jul 2018 09:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QD7rRZVKDQxDGPAj7aoVtV0Jww17S6QJHzlfBCyt/c0=; b=HWpCj8zVot4A+TjS0VvSMIEh/UMOlt7E8i2uZ1RsdYEX6Ti7QCODdrClxqjcGsxkMg uoKSK5xHaWoS1zZKggtx6RPlALMc+UnIAxHRPEQAor+v4ijfQ9al8GW/omFULzX/fsYs 8gdobAa0r5wjxeMv2r1HsxqB/+Sq+ams+pKtlaHSpVMM+a1mgLcmchZ7pYQqWRSs7TaF +aP3mp9sW69ynlJFlmTWS96atJlkftrM9ZpY1zG4iLIcxLCqHLB6EmtWrZa0M+M+PAc6 HQ6Feyb45/7j/fTla5x0YmsRv9QWPab9IoF6aQIn6XfaULm0AObKcm7Yrmo5JcGqLMO6 4YZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QD7rRZVKDQxDGPAj7aoVtV0Jww17S6QJHzlfBCyt/c0=; b=k2MniSIpCLxPYd/pgGo8SrE0TDnKvhLavOU40b2a7jFVZeeDUqV9hDI8JzTLCrcYi0 YA/K7eCzSJUZK0F0Am89/xocyJvR6fcF2p32DZ3aKfaK4wkfezzeumvsFKES3hhT33nP d4VMHjsj0nDHURT5fp+GwGm/2DrzqRGMUxQAzbk810aVMUtHWOy1p+uEvoi1J5tU3oSp a0UV3yjuNcgqJ7IthRjOz9XasNLBDlqv1ZrND1kTnL3pLmr4PP0pzDy1DVA1X0NF285n 5jijGkNjmdgHGArCCY44U76wPzCChSj11EhPl+Zn8REFETjWcQk7XyAF1c/+Q0Md7Uwk GM5g== X-Gm-Message-State: APt69E1Dyn/uKSjMKv1tIBCIXqCzpV/K136T4ohETiI/Hz9xSGullWAy VeGnaMJzZzEaoS0R5dUuoTXpQpRlyn6IDxHqYXlVKQ== X-Google-Smtp-Source: AAOMgpfY1enY7w7VZK/1jVWd8EG0nyNgE74RGf7kP1po/vZncVaPl3rA6FOgPbEbrUcSN+7ngN1qML9H8oGEpNym6S0= X-Received: by 2002:a81:93c6:: with SMTP id k189-v6mr2463783ywg.41.1530809425629; Thu, 05 Jul 2018 09:50:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:b90:0:0:0:0:0 with HTTP; Thu, 5 Jul 2018 09:50:25 -0700 (PDT) In-Reply-To: <201807051638.w65GctbL044633@repo.freebsd.org> References: <201807051638.w65GctbL044633@repo.freebsd.org> From: Oliver Pinter Date: Thu, 5 Jul 2018 18:50:25 +0200 Message-ID: Subject: Re: svn commit: r335999 - in head/sys: amd64/amd64 i386/i386 To: Konstantin Belousov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 16:50:27 -0000 On Thursday, July 5, 2018, Konstantin Belousov wrote: > Author: kib > Date: Thu Jul 5 16:38:54 2018 > New Revision: 335999 > URL: https://svnweb.freebsd.org/changeset/base/335999 > > Log: > In x86 pmap_extract_and_hold(), there is no need to recalculate the > physical address, which is readily available after sucessfull > vm_page_pa_tryrelock(). Hi! Wrong commit message. > > Noted and reviewed by: alc > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D16085 > > Modified: > head/sys/amd64/amd64/pmap.c > head/sys/i386/i386/pmap.c > > Modified: head/sys/amd64/amd64/pmap.c > ============================================================ > ================== > --- head/sys/amd64/amd64/pmap.c Thu Jul 5 16:30:32 2018 (r335998) > +++ head/sys/amd64/amd64/pmap.c Thu Jul 5 16:38:54 2018 (r335999) > @@ -2308,7 +2308,6 @@ retry: > PG_PS_FRAME) | (va & PDRMASK), &pa)) > goto retry; > m = PHYS_TO_VM_PAGE(pa); > - vm_page_hold(m); > } > } else { > pte = *pmap_pde_to_pte(pdep, va); > @@ -2318,10 +2317,10 @@ retry: > &pa)) > goto retry; > m = PHYS_TO_VM_PAGE(pa); > - if (m != NULL) > - vm_page_hold(m); > } > } > + if (m != NULL) > + vm_page_hold(m); > } > PA_UNLOCK_COND(pa); > PMAP_UNLOCK(pmap); > > Modified: head/sys/i386/i386/pmap.c > ============================================================ > ================== > --- head/sys/i386/i386/pmap.c Thu Jul 5 16:30:32 2018 (r335998) > +++ head/sys/i386/i386/pmap.c Thu Jul 5 16:38:54 2018 (r335999) > @@ -1673,7 +1673,6 @@ retry: > PG_PS_FRAME) | (va & PDRMASK), &pa)) > goto retry; > m = PHYS_TO_VM_PAGE(pa); > - vm_page_hold(m); > } > } else { > pte = pmap_pte_ufast(pmap, va, pde); > @@ -1683,10 +1682,10 @@ retry: > &pa)) > goto retry; > m = PHYS_TO_VM_PAGE(pa); > - if (m != NULL) > - vm_page_hold(m); > } > } > + if (m != NULL) > + vm_page_hold(m); > } > PA_UNLOCK_COND(pa); > PMAP_UNLOCK(pmap); > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >