From owner-cvs-all Thu Oct 31 1:51:17 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28FD637B401; Thu, 31 Oct 2002 01:51:16 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0C5343E7B; Thu, 31 Oct 2002 01:51:15 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id B4BC6AE265; Thu, 31 Oct 2002 01:51:15 -0800 (PST) Date: Thu, 31 Oct 2002 01:51:15 -0800 From: Alfred Perlstein To: Bruce Evans Cc: Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio findfp.c Message-ID: <20021031095115.GW24139@elvis.mu.org> References: <20021031020030.33A952A89D@canning.wemm.org> <20021031202925.Y8632-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021031202925.Y8632-100000@gamplex.bde.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Bruce Evans [021031 01:25] wrote: > On Wed, 30 Oct 2002, Peter Wemm wrote: > > > Alfred Perlstein wrote: > > > alfred 2002/10/30 17:54:27 PST > > > > > > Modified files: > > > lib/libc/stdio findfp.c > > > Log: > > > Make __sF static. This can not be allowed to exist in 5.x. > > > > Heh, I so badly wanted to do this, but couldn't quite work up the nerve. > > You already did, but thought better of it. > > "Fixing" signal handling broke even more things here. Old kernels can no > longer run many new binaries because new binaries use the new sigaction() > syscall just to select the type of signal context passed to signal handlers, > most of which don't care about the type. While this is true and you are correct, I don't see how this reflects negatively on the decision to statisize __sF. The idea it to get rid of this in a fashion that while somewhat aburbt saves us from pain later if we choose to resize the struct FILE (which would cause much weirder breakage). -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message