From owner-p4-projects@FreeBSD.ORG  Sun Jun 14 13:14:18 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5C1051065670; Sun, 14 Jun 2009 13:14:18 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1BD86106566B
	for <perforce@FreeBSD.org>; Sun, 14 Jun 2009 13:14:18 +0000 (UTC)
	(envelope-from gabor@FreeBSD.org)
Received: from server.mypc.hu (server.mypc.hu [87.229.73.95])
	by mx1.freebsd.org (Postfix) with ESMTP id BB8428FC0C
	for <perforce@FreeBSD.org>; Sun, 14 Jun 2009 13:14:17 +0000 (UTC)
	(envelope-from gabor@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by server.mypc.hu (Postfix) with ESMTP id ED7E514D8751;
	Sun, 14 Jun 2009 15:14:16 +0200 (CEST)
X-Virus-Scanned: amavisd-new at t-hosting.hu
Received: from server.mypc.hu ([127.0.0.1])
	by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id BR8BQxYRRP-J; Sun, 14 Jun 2009 15:14:16 +0200 (CEST)
Received: from [192.168.1.105] (catv-80-98-231-64.catv.broadband.hu
	[80.98.231.64])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by server.mypc.hu (Postfix) with ESMTPSA id EF5A414D5280;
	Sun, 14 Jun 2009 15:14:15 +0200 (CEST)
Message-ID: <4A34F7A5.7090502@FreeBSD.org>
Date: Sun, 14 Jun 2009 15:14:13 +0200
From: Gabor Kovesdan <gabor@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: David Forsythe <dforsyth@FreeBSD.org>
References: <200906110517.n5B5H4Or055869@repoman.freebsd.org>
In-Reply-To: <200906110517.n5B5H4Or055869@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 164069 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jun 2009 13:14:19 -0000

David Forsythe escribió:
> @@ -13,6 +13,16 @@
>  /* Create a new pkg. */
>  
>  struct pkg *
> +pkg_new()
>   
This should be pkg_new(void), I think. This is the normal ANSI 
prototype, the empty parentheses were for old-style K&R C declarations.

-- 
Gabor Kovesdan
FreeBSD Volunteer

EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org
WEB:   http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org