From owner-svn-src-all@freebsd.org Fri Jan 18 08:58:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0A2914947C8; Fri, 18 Jan 2019 08:58:13 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 536C884A2F; Fri, 18 Jan 2019 08:58:13 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id x0I8w1u0085847 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Jan 2019 09:58:04 +0100 (CET) (envelope-from eugen@freebsd.org) X-Envelope-From: eugen@freebsd.org X-Envelope-To: cem@freebsd.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id x0I8vxsX064930 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 18 Jan 2019 15:58:00 +0700 (+07) (envelope-from eugen@freebsd.org) Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim To: cem@freebsd.org References: <201901171808.x0HI80jC068564@repo.freebsd.org> <2d239dc0-915c-2d2b-0936-a40af5e9ead9@freebsd.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Eugene Grosbein Message-ID: Date: Fri, 18 Jan 2019 15:57:54 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 536C884A2F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.991,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 08:58:14 -0000 18.01.2019 4:45, Conrad Meyer wrote: >>> Please back it out; stop attributing code review to "hackers@," which >>> can not (it's a list, not individuals) and did not review this >>> changeset; and put it on phabricator for actual review. >> >> There is already https://reviews.freebsd.org/D18380 by imp >> and there were over 6 weeks since it had an update. >> Newly committed code has most of its changes. > > Your response does not address *any* of the above concerns. It's just > unrelated. > > The review you linked to isn't one you submitted for this change; This is a review still. > it's Warner's, and that one stalled because you were such a jerk to him This is not true. > last time that he needed time off from you. Please do not speak for him. > If you want to socialize, revive, or expedite someone else's review, > maybe add a new comment to the review, I did. > or post a discussion hackers@, I did. > or something like that. You still can't attribute code review to > hackers@, especially as no such review happened. It happened a week before I make first commit, in a way. I cannot make people do a review if they do not want to review. And we still had no utility to do the job.