From nobody Sat Aug 8 11:59:21 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hHKLd48pJz6nYSt for ; Sat, 08 Aug 2026 11:59:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hHKLd3K81z3Mk9 for ; Sat, 08 Aug 2026 11:59:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786190361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JV8ujWdtiEYbP8yXOpE9imZyENUWCmfMcObeG1y2gvM=; b=juERi1JC7HNEvfz8nn/oTOHiPTH6w51yZl3RhS+sKTT6nq2zHw8WznC+PNbju9Vc7DCALF hUF5Sd0qUOmhO+nA1o6XSLWgyoimtBKJ0lbJeVqXAHAWFUeXNnyhZX98vKfnC8caaYMUqL mfOx6y4banuDpPGagDtR2/fIDDIGkgClvFg3VOGM3gUN63QRReVR9hwoP79YZBsn8QYaXU 12lkj1yvMaUfrxaAUu2qBB2hGmqZQYG68dGG9SXeqW8415u8m36e62MPkBa3fuUnps4K3p Ae83ICnkvV3yLzvKPKK9wmTLMM+w9j/MLsEYD6L55qV5fV4ZXDGzhoRpIegZ+A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786190361; a=rsa-sha256; cv=none; b=pGpSDwTqdx/yc0R2QRRjYAYRuuIqtgHD1lxBCF29OF8GpThpaLuZRp0GL2ExkC5biSu+UA 3pursvYktuSFi8Kk9kPD16LmNJ3Wf5Yznz/rnxhULhAC2/i1mlYjHW76pqKPdp0PqYxhcE CKgBRbwpuxOV/9VNCu7qySJny9ujOms+oeKS3SmLcderGof/VqZXywQVlzk3UFpaNjoIO4 CJKz+VE8cOLEPoSZtBlx2gK+JNkpqeHSuhYTGQ59XmiAmVCFIWLiaf4IRCkbclVMov98wN IppTEl87CT9Xh64fH4dFp1mZhMSdr8sTWlMfoqoUbWo7Zd/jgwql7z7hCpWL+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786190361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JV8ujWdtiEYbP8yXOpE9imZyENUWCmfMcObeG1y2gvM=; b=YxAHoDAaY6tyrwBbqzr2kBqdoblT3QHMMdU3WUQ/qUfenC/czfrOkniysR7tp7gxWo+x6p Pf4EoBIjSTFJ1D+cQCJL5LnRJk8o6teWQ427aiNf759cVZyIQAq/NcjIRAhKcq13ezOXVG f6Gi/i9arUO6Ud8xpIRrS465mXRl0q+2gopZAB0vGovVX9tzOWsSd2loXp0gbeo4TMeg5X du95omdLR9UACF93e/ZE/43QWDnHgF1sD9wx7F1T2xnwX/HMiKEEG9SeLUSE8q6DxQnGa1 nQFyoNRJDuElqZhQwD/OLVdioIXcNGuuLCJpV49FrpZ0lq7G2QAEBp8fPvA35A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hHKLd2BjMzcY1 for ; Sat, 08 Aug 2026 11:59:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 35fca by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 11:59:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: c017bceda48c - main - ixgbe: Reject Flow Director with SR-IOV List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c017bceda48c766780ab1d2239b296242fcf9cf2 Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 11:59:21 +0000 Message-Id: <6a771a19.35fca.7d9e8972@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c017bceda48c766780ab1d2239b296242fcf9cf2 commit c017bceda48c766780ab1d2239b296242fcf9cf2 Author: Kevin Bowling AuthorDate: 2026-08-08 11:11:09 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 11:59:13 +0000 ixgbe: Reject Flow Director with SR-IOV The iflib Flow Director path does not assign filters using the absolute queue and pool identifiers required by SR-IOV. Reject the combination during preflight validation rather than allowing an unsupported configuration to alter the PF receive path. The loader tunable is fixed before VFs can be created, so validation also prevents the reverse ordering of this combination. MFC after: 2 weeks --- share/man/man4/ix.4 | 3 ++- sys/dev/ixgbe/if_sriov.c | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/share/man/man4/ix.4 b/share/man/man4/ix.4 index 822a8040caf4..33b723c0fcd2 100644 --- a/share/man/man4/ix.4 +++ b/share/man/man4/ix.4 @@ -29,7 +29,7 @@ .\" .\" * Other names and brands may be claimed as the property of others. .\" -.Dd August 7, 2026 +.Dd August 8, 2026 .Dt IX 4 .Os .Sh NAME @@ -168,6 +168,7 @@ Enable Flow Director. Flow Director directs Ethernet packets to the core where the packet consuming process, application, container, or microservice is running. +SR-IOV configuration is rejected when Flow Director is enabled. .It Va hw.ix.enable_rss Enable Receive-Side Scaling (RSS). When RSS is enabled, all of the receive data processing for diff --git a/sys/dev/ixgbe/if_sriov.c b/sys/dev/ixgbe/if_sriov.c index ff873d4652f8..4e98b2b5de0c 100644 --- a/sys/dev/ixgbe/if_sriov.c +++ b/sys/dev/ixgbe/if_sriov.c @@ -1698,6 +1698,11 @@ ixgbe_iov_validate(struct ixgbe_softc *sc, u16 num_vfs) if (sc->vfs != NULL || sc->vf_mac_filters != NULL || (sc->feat_en & IXGBE_FEATURE_SRIOV)) return (EBUSY); + if (sc->feat_en & IXGBE_FEATURE_FDIR) { + device_printf(sc->dev, + "Flow Director is not supported with SR-IOV\n"); + return (ENOTSUP); + } if (sc->intr_type != IFLIB_INTR_MSIX) { device_printf(sc->dev, "SR-IOV requires MSI-X\n"); return (ENOTSUP);