From owner-svn-src-all@freebsd.org Fri Dec 28 19:02:17 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C431141F1BF; Fri, 28 Dec 2018 19:02:17 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F17FE96075; Fri, 28 Dec 2018 19:02:16 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 43RGKg4kDKzDjFf; Fri, 28 Dec 2018 19:02:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id hyhiu73-pgvA; Fri, 28 Dec 2018 19:02:15 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:25be:edfd:c331:f8d8]) by mail.daemonic.se (Postfix) with ESMTPSA id 43RGKf7065zDjFd; Fri, 28 Dec 2018 19:02:14 +0000 (UTC) Subject: Re: svn commit: r342389 - head/share/man/man5 To: Chris Rees , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201812241047.wBOAlmwc092761@repo.freebsd.org> <1c2d5b66-42f2-63e6-9f62-aa383e9b79b9@freebsd.org> <5766D4AE-C093-4B48-9570-E4FC84E63CF2@FreeBSD.org> From: Niclas Zeising Message-ID: Date: Fri, 28 Dec 2018 20:02:14 +0100 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <5766D4AE-C093-4B48-9570-E4FC84E63CF2@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F17FE96075 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 19:02:17 -0000 On 12/28/18 7:43 PM, Chris Rees wrote: > Hey, > > On 28 December 2018 18:19:57 GMT+00:00, Niclas Zeising wrote: >> On 12/24/18 11:47 AM, Chris Rees wrote: >>> Author: crees (doc,ports committer) >>> Date: Mon Dec 24 10:47:48 2018 >>> New Revision: 342389 >>> URL: https://svnweb.freebsd.org/changeset/base/342389 >>> >>> Log: >>> Clarify kld_list format >>> >>> PR: docs/234248 >>> Submitted by: David Fiander >>> Submitted by: Miroslav Lachman >>> >>> Modified: >>> head/share/man/man5/rc.conf.5 >>> >>> Modified: head/share/man/man5/rc.conf.5 >>> >> ============================================================================== >>> --- head/share/man/man5/rc.conf.5 Mon Dec 24 06:14:32 2018 (r342388) >>> +++ head/share/man/man5/rc.conf.5 Mon Dec 24 10:47:48 2018 (r342389) >>> @@ -248,12 +248,14 @@ Default >>> .Pa /etc/ddb.conf . >>> .It Va kld_list >>> .Pq Vt str >>> -A list of kernel modules to load right after the local >>> -disks are mounted. >>> +A whitespace-separated list of kernel modules to load right after >>> +the local disks are mounted, without any >>> +.Pa .ko >>> +extension or path. >>> Loading modules at this point in the boot process is >>> much faster than doing it via >>> .Pa /boot/loader.conf >>> -for those modules not necessary for mounting local disk. >>> +for those modules not necessary for mounting local disks. >>> .It Va kldxref_enable >>> .Pq Vt bool >>> Set to >> >> >> Hi! >> Sorry for jumping into this so late. >> Please please PLEASE don't break loading modules by path in kld_list. >> This is used by the drm-kmod files to distinguish them from the base >> modules, and this has been communicated in documentation all over the >> place, including numerous ports. >> >> Can this please be reverted, or amended to match reality. >> >> In practice, adding both the path and the extension (.ko) to a module >> in >> kld_list works and the module loads. > > As the code itself stands, it works for loading, but throws an error if you try to load an already loaded module adding a .ko extension. In other words, it works but is wrong. The path actually still does work, which was my mistake. > > I'm awaiting approval for this, which correctly handles all cases: > > https://reviews.freebsd.org/D18670 > > Konstantin has reviewed, but doesn't feel comfortable giving approval as it's not his area, which is fair enough. > > Chris > Ok. Will this continue to work when loading /path/to/foo.ko rather than path/to/foo? (I assume it will) Regards -- Niclas Zeising