Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jul 2015 14:02:49 -0400
From:      Benjamin Kaduk <bjkfbsd@gmail.com>
To:        Zbigniew Bodek <zbb@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r285627 - in head/sys: arm/arm arm/at91 arm/cavium/cns11xx arm/samsung/s3c2xx0 arm/xscale/i80321 arm/xscale/i8134x arm/xscale/ixp425 arm/xscale/pxa arm64/arm64 ddb i386/i386 powerpc/boo...
Message-ID:  <CAJ5_RoBkD0O3KzUoTaim20Vk7gkmKOAoDmmipmYNd23JmS5kbg@mail.gmail.com>
In-Reply-To: <201507161046.t6GAkrEt028784@repo.freebsd.org>
References:  <201507161046.t6GAkrEt028784@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 16, 2015 at 6:46 AM, Zbigniew Bodek <zbb@freebsd.org> wrote:

> Author: zbb
> Date: Thu Jul 16 10:46:52 2015
> New Revision: 285627
> URL: https://svnweb.freebsd.org/changeset/base/285627
>
> Log:
>   Fix KSTACK_PAGES issue when the default value was changed in KERNCONF
>
>   If KSTACK_PAGES was changed to anything alse than the default,
>   the value from param.h was taken instead in some places and
>   the value from KENRCONF in some others. This resulted in
>   inconsistency which caused corruption in SMP envorinment.
>
>   Ensure all places where KSTACK_PAGES are used the opt_kstack_pages.h
>   is included.
>

This leads to the question: why is KSTACK_PAGES defined in param.h at all,
if the value will be incorrect for custom kernel configurations?

-Ben



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoBkD0O3KzUoTaim20Vk7gkmKOAoDmmipmYNd23JmS5kbg>