From owner-svn-src-head@freebsd.org Mon May 27 22:34:50 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A62F015ACFAF for ; Mon, 27 May 2019 22:34:50 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F1E089BA9 for ; Mon, 27 May 2019 22:34:49 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1558996479; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=ZBld/4gmOF2g3eMnUME5eFhl9aAVFy20WYBRZ03JGsPnCOStRg2CeJnPeiNTCxCLAs2//cYCoYECo xaqkZVWQVopfF4qVqf8By94twc7QmR6e+ipD/4apLk2LE8bo+R7rlzJaZgqK9f79hi6eS+dgIOIz0y o/evAUV8ubt86jhposmZMcZFRulgIG+ZHV0w63dRuuLzq2y5BAGF1gqhKIJ2GDkVN+jAiBnQo+IT4O dq50Y0cH++iwn+i+7TvUYAb1Eaiw7fPB3pHvJExYs+xLepuG+KDI6AWPySHs7xrI8J102mk5/IX3hf 0o138+HhaqNNJNe7FG6NsI3P3xkkZGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=z8H68u9UtwRqTRHsj2ravb+n6HaWN/sesibtKqgH6+s=; b=AjtU5DwPneHrsFe5VmcMPJtuGKGRh17JBgkXgfor8X5AhOwUc5Wg/77bqI6KDllQFysnd+LmKjvFS QkDVMzOJOw53JedYnnt15mE0bqfbnkOcGry7VhAOZhv6rknUItjdk02e1zpFIPc8PwIooWIQjZWCR3 zdURra3VH/3jwsChNAbCTVvLvfiR57ACrRY2Ps4zy6ImlA1sKY7QRHnI1A9ENzeui2BcM1NvfVIswt Pugf522YVH4MR4w8K+TwPQPTfGMKIGa5i/zNsOx7XwB8etmuP5a/Hb96vsvPzIBDULsPaeyxUZyHJ3 EmAAdQEZTvVVug2uuBHF/k93HZyzfiQ== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=z8H68u9UtwRqTRHsj2ravb+n6HaWN/sesibtKqgH6+s=; b=M1GEu7ftWGIIXvf02H8vXcIG78M6Zwjm4EdV7DCQWI+vEBxKc62+JyjC2rBHbuyWasSYZwT+/0kfa PWYwsKcHfguM9+/MRwPBxMI1dYG44QN4qOsOBONTY78K3HS3fKI7oH66zGj8J02LPa+JV6DmqsCs7W Sco0dOncuRjFKk5wohzIIw+hO7nehrRR9kcNB4w8ZUHXD9eRZKG+zKbJoCucDYVEJEHDDNGSnjNf16 sCZXQD1e9sNYNNiS0LGbnjMzC77/fpTO3fHaQVBatTJRTguVjnhL5wKDuTLwLMnPH9AtkntD0iieR7 gXCd73Eg2FoshlnFVJLXV+uUNdd1gxA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 9abfe2cf-80cf-11e9-91aa-b56e4e6b5865 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 9abfe2cf-80cf-11e9-91aa-b56e4e6b5865; Mon, 27 May 2019 22:34:37 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x4RMYZUJ028394; Mon, 27 May 2019 16:34:35 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r232071 - head/sys/vm From: Ian Lepore To: rgrimes@freebsd.org, Alexey Dokuchaev Cc: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 27 May 2019 16:34:34 -0600 In-Reply-To: <201905272134.x4RLY9oO012473@gndrsh.dnsmgr.net> References: <201905272134.x4RLY9oO012473@gndrsh.dnsmgr.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0F1E089BA9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 May 2019 22:34:50 -0000 On Mon, 2019-05-27 at 14:34 -0700, Rodney W. Grimes wrote: > I just ask that before a change be made that starts from some > static analysis tool that a formal code review occur before > the change is committed. In a word: No. We're not talking about some inexperienced coder committing dumb fixes to silence warnings here. What I've seen so far is that fixes are being committed by the people who originally wrote or currently maintain the code in question. Nothing bad is happening, so nothing about the process needs to be fixed or changed in any way. Process for process' sake is just obstruction. -- Ian