From owner-freebsd-bugs@FreeBSD.ORG Sat Aug 21 19:47:48 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D91CC10656A7; Sat, 21 Aug 2010 19:47:48 +0000 (UTC) (envelope-from vwe@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CAA0D8FC08; Sat, 21 Aug 2010 19:47:48 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7LJlmUU098471; Sat, 21 Aug 2010 19:47:48 GMT (envelope-from vwe@freefall.freebsd.org) Received: (from vwe@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7LJlmnw098467; Sat, 21 Aug 2010 19:47:48 GMT (envelope-from vwe) Date: Sat, 21 Aug 2010 19:47:48 GMT Message-Id: <201008211947.o7LJlmnw098467@freefall.freebsd.org> To: thomas.swan@gmail.com, vwe@FreeBSD.org, freebsd-bugs@FreeBSD.org From: vwe@FreeBSD.org Cc: Subject: Re: bin/139314: [patch] install(1): install -d reports success on failure X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2010 19:47:48 -0000 Old Synopsis: install(1): install -d reports success on failure New Synopsis: [patch] install(1): install -d reports success on failure State-Changed-From-To: open->analyzed State-Changed-By: vwe State-Changed-When: Sat Aug 21 19:42:44 UTC 2010 State-Changed-Why: I'm somewhat undecided about this report. IMO if a tool is being told to do one thing and it can't be done, it can be seen as a failure. If install is able to install a file / directory but isn't able to set modes or owner (when told do set them), it should be seen as a failed job (do everything right or signal error, but not do half the way right). Changing that may break a lot of places where install is being used. I've created a patch for that which is signalling a failure if mode or owner can't be set only when -T has been given. The patch can be found at: http://people.freebsd.org/~vwe/files/patches/pr139314_xinstall.diff but I'm really not happy about that. Either use something similar to my patch or we can close this PR as WONTFIX. http://www.freebsd.org/cgi/query-pr.cgi?pr=139314