From nobody Sat Jun 20 16:07:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjK9B31M3z6jnHP; Sat, 20 Jun 2026 16:07:10 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjK9B0sT1z3HdV; Sat, 20 Jun 2026 16:07:10 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781971630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xtUxOmc7YwzKyJS4Dvt7KKA64r7aRevqclktv6/z3pU=; b=l+S1/MURBrdt1jOxaSOHphlD+mWZIaww4QLIW8r7Ps9O8yIvQGxszPuhX07Hp0iPqBsoKE PHeYfXI+T5ZPhsHyzsLkETqG2sDVZIugdePgWR26BT5mw6Ghf1SHhj4i70F6pMQqYXhv45 eZ39AmAZhpE3qhz8dq7E1t24zEJj0qNG7WjTHp8HXv1fLAiKdCBVH/4E63qH4dhHtJUD5q 4QEY3uKDgqUxADIKE9NWbfYTpwb9uFM9YPt6otsO2z3zniIN4YhwKA1Grlzr9jcITJI5aR obHJjh8rD/tVq05gsnY/W129bfUuYm3x19ueqoNMOEb5DT2e/+dbPZ892aqmGQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781971630; a=rsa-sha256; cv=none; b=qnm6P03u4EPFuZru9sBG+75td4Jn+4XwilOaSi9Ub2DInoC+cSLGFd46I+/t24W266YsTa hO6Rk6kgf0KKq3YKexant/n6ey5hGkHh0sS1sSRRov3Nv1oHr/89yTmfAQ2u4iM7Ll7xHv zdJU8tp3Vectv+AOvH+urF7SCuGb5OU44dhDboLJ5ay8UyLuyZTlEGEx0N7QUWGlb4oSF5 J6T5av0cVIgzjArvN2eZiVvAH2avJYJQM8m4riVIcbZY/MHGBZk51kFCQiUMRL3wDE6l++ O7MqGjMF1P7KCADlTgvuk72Vd4ugoscN2zp0pHl0RENfsCL2O1y4wV9yIYCuoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781971630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xtUxOmc7YwzKyJS4Dvt7KKA64r7aRevqclktv6/z3pU=; b=fT/U+jlEwT1TO6pKtSiNtzVWp+7eGDlzLTh2qXF723IXVnFTe08F6HCjbPJsDl/znbGA3o hMoWm9VvDLREMDdUXX1GAyQ3ukpR7cYrJM06+ynay6V/HxmJsfxHt9/j3sBktvTsKpuub2 5XbwbVxcnoJ9T4hQWCP9rm8//I/icMi7s6QrZ7Dz9hHoU+7vkbUvU84tJbjo7dgVeyHSjX K5r5f65ALYJZkQb6qOwol/qQB5dBd5gpoPVxAUQflsoAWLQeBRLnBXk3YSVgerMTfs5rzW I5nub+c2jckc4bh1pOP9ZuGGGMAZeG8TDsjr0kkqQfao3QKkb9nDlPZtgbY9bw== Received: from ltc.des.dev (unknown [92.183.55.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gjK995cK1zCtq; Sat, 20 Jun 2026 16:07:09 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 4896950710; Sat, 20 Jun 2026 18:07:08 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Mark Johnston Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 949804c81909 - main - nvme: Use newbus to ask if a device is storage In-Reply-To: (Mark Johnston's message of "Sat, 20 Jun 2026 10:20:29 -0400") References: <6a32b7af.3e162.34185707@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 20 Jun 2026 18:07:08 +0200 Message-ID: <86qzm1tcur.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mark Johnston writes: > Warner Losh writes: > > + static bool > > + default_is_storage_device(device_t dev) > > + { > > + return (true); > > + } > After this commit I see a warning during buildkernel of a GENERIC > kernel: > > nvme_if.c:21:1: warning: unused function 'default_is_storage_device' [-Wu= nused-function] Easily fixed by changing `static bool` to `static inline bool`. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org