From owner-svn-src-all@FreeBSD.ORG  Fri Jan  7 20:32:28 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 820D8106566B;
	Fri,  7 Jan 2011 20:32:28 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D8D08FC1C;
	Fri,  7 Jan 2011 20:32:27 +0000 (UTC)
Received: by gwj21 with SMTP id 21so8420826gwj.13
	for <multiple recipients>; Fri, 07 Jan 2011 12:32:27 -0800 (PST)
Received: by 10.236.110.5 with SMTP id t5mr19622552yhg.8.1294432347419; Fri,
	07 Jan 2011 12:32:27 -0800 (PST)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.236.108.51 with HTTP; Fri, 7 Jan 2011 12:32:07 -0800 (PST)
In-Reply-To: <201101072026.p07KQXKe064774@svn.freebsd.org>
References: <201101072026.p07KQXKe064774@svn.freebsd.org>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Fri, 7 Jan 2011 12:32:07 -0800
X-Google-Sender-Auth: JyXRZMyRcyoUOaYVgphGYnaTa1c
Message-ID: <AANLkTimuCCTsYczrKOewyxVOuZgnbPsy9iQUgGKtiGXb@mail.gmail.com>
To: Warner Losh <imp@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r217123 - in head: . gnu/lib/libgcc gnu/lib/libgomp
 gnu/usr.bin/binutils gnu/usr.bin/binutils/ld
 gnu/usr.bin/binutils/libbfd
 gnu/usr.bin/cc gnu/usr.bin/gdb gnu/usr.bin/gdb/libgdb lib/li...
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jan 2011 20:32:28 -0000

On Fri, Jan 7, 2011 at 12:26, Warner Losh <imp@freebsd.org> wrote:
> --- head/gnu/lib/libgcc/Makefile =A0 =A0 =A0 =A0Fri Jan =A07 20:07:30 201=
1 =A0 =A0 =A0 =A0(r217122)
> +++ head/gnu/lib/libgcc/Makefile =A0 =A0 =A0 =A0Fri Jan =A07 20:26:33 201=
1 =A0 =A0 =A0 =A0(r217123)
> @@ -119,9 +119,10 @@ LIB2FUNCS_EXTRA =3D floatunsidf.c floatuns
> =A0# =A0 =A0 =A0_fixsfsi _fixunssfsi _floatdidf _floatdisf
> =A0.endif
>
> -.if ${TARGET_CPUARCH} =3D=3D "mips"
> +.if ${TARGET_CPUARCH} =3D=3D mips
> =A0LIB2FUNCS_EXTRA =3D floatunsidf.c floatunsisf.c
> -.if defined(TARGET_ABI) && ${TARGET_ABI} !=3D "o32"
> +# XXX do we need n32 here?
> +.if ${TARGET_ARCH:Mmips64*} !=3D ""

Almost certainly.  n32 fails the !=3D o32 check.  I was careful when I
made the TARGET_ABI changes.  There's a possibility that this was
wrong for some reason, but I'm skeptical.


=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/lib/libc/Makefile =A0 =A0 =A0Fri Jan =A07 20:07:30 2011 =A0 =A0 =
=A0 =A0(r217122)
> +++ head/lib/libc/Makefile =A0 =A0 =A0Fri Jan =A07 20:26:33 2011 =A0 =A0 =
=A0 =A0(r217123)
> @@ -68,11 +68,7 @@ NOASM=3D
> =A0 =A0 ${LIBC_ARCH} !=3D "ia64" && \
> =A0 =A0 ${LIBC_ARCH} !=3D "powerpc64" && \
> =A0 =A0 ${LIBC_ARCH} !=3D "sparc64" && \
> - =A0 =A0${LIBC_ARCH} !=3D "mips"
> -.include "${.CURDIR}/quad/Makefile.inc"
> -.endif
> -.if ${LIBC_ARCH} =3D=3D "mips" && \
> - =A0 =A0(!defined(TARGET_ABI) || ${TARGET_ABI} =3D=3D "o32")
> + =A0 =A0${MACHINE_ARCH:Mmips64*} =3D=3D ""
> =A0.include "${.CURDIR}/quad/Makefile.inc"

Here it's definitely wrong to restate !=3Do32 as =3D=3Dn64; n32 doesn't nee=
d
soft quads, it has 64-bit registers.

Thanks,
Juli.