From owner-svn-ports-all@freebsd.org  Thu Jun  2 09:45:04 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7C73B64807;
 Thu,  2 Jun 2016 09:45:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id DDC6E1C07;
 Thu,  2 Jun 2016 09:45:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id DC8B51714; Thu,  2 Jun 2016 09:45:04 +0000 (UTC)
Date: Thu, 2 Jun 2016 09:45:04 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: David Naylor <dbn@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r416256 - head/emulators/i386-wine-devel
Message-ID: <20160602094504.GB40856@FreeBSD.org>
References: <201606011902.u51J2vW4090093@repo.freebsd.org>
 <F4C3268C2E9A44F7323C8446@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F4C3268C2E9A44F7323C8446@atuin.in.mat.cc>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2016 09:45:05 -0000

On Thu, Jun 02, 2016 at 01:29:12AM +0200, Mathieu Arnold wrote:
> This is completely bogus, you can't have more than one TIMESTAMP line, how
> did you manage to generate that file ?

I've tried to warn you that these things will happen, but you won't listen.
OK, let's try again.

- Unattached TIMESTAMP is bogus as it is not clear what distfile it is
  related to.  (If it does not relate to any of them, it should not be part
  of distinfo.)  No, you cannot expect that your code is flawless or that
  committers won't have their own procedures to generate/maintain distinfo;

- It should not be set by committer: this is error prone and it is possible
  to set it deliberately to some wrong value (e.g. 0) which might break
  things in a weird way.  Even when there's no ill will involved, it is not
  wise to trust local clock as that might not be accurate: two commits in a
  short time window might result in TIMESTAMP value go *backwards* because
  of untuned clock, DST shift not applied correctly, etc.

Bottom line: it should be set by the SVN, server-side, and not mix this with
other data.  Baptiste said keywords is not an option because we officially
support broken VCS that does not support them (Git), but in this case IMO it
could be emulated (and thus stored in expanded form) via commit hook (simply
replace first line with a new one; line should be commented out and maybe
marked as ``# $Timestamp: $'' to look like real keyword and help to avoid
messing with real data line SIZE() and SHA256() values).

./danfe