From owner-svn-ports-all@freebsd.org  Tue Jan  2 18:52:01 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF39AEB38B7;
 Tue,  2 Jan 2018 18:52:01 +0000 (UTC) (envelope-from yuri@rawbw.com)
Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42])
 by mx1.freebsd.org (Postfix) with ESMTP id A34436D323;
 Tue,  2 Jan 2018 18:52:01 +0000 (UTC) (envelope-from yuri@rawbw.com)
Received: from yv.noip.me (c-24-6-186-56.hsd1.ca.comcast.net [24.6.186.56])
 (authenticated bits=0)
 by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w02Iq0m3077132
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Tue, 2 Jan 2018 10:52:01 -0800 (PST) (envelope-from yuri@rawbw.com)
X-Authentication-Warning: shell1.rawbw.com: Host
 c-24-6-186-56.hsd1.ca.comcast.net [24.6.186.56] claimed to be yv.noip.me
Subject: Re: svn commit: r457914 - in head: . Mk/Uses astro/kstars
 audio/csound6 biology/iqtree cad/freecad cad/openscad
 deskutils/kdeplasma-addons editors/calligra games/xptools graphics/code-eli
 graphics/colm...
To: "Tobias C. Berner" <tcberner@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201801021649.w02GnOap052049@repo.freebsd.org>
From: Yuri <yuri@rawbw.com>
Message-ID: <87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9@rawbw.com>
Date: Tue, 2 Jan 2018 10:51:59 -0800
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <201801021649.w02GnOap052049@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jan 2018 18:52:02 -0000

On 01/02/18 08:49, Tobias C. Berner wrote:
>      Usage:
>        USES=eigen:<version>[,<type>]
>    
>        version: 2 or 3 (required)
>        type:    build (default), run


I have 3 questions:


1. Why doesn't eigen.mk check for invalid argument values? For example, 
USES=eigen:3,4,build,run doesn't cause an error as it should. I had the 
same question about other USES modules, but am asking here because 
eigen.mk is freshly added. It seems like checking for invalid values can 
be a good idea?


2. Maybe it would be beneficial to explain in the module when particular 
arguments should be used:

USES=eigen:{2,3} (defaults to build) - should be used when the port uses 
Eigen headers during build, but doesn't install any headers that depend 
on Eigen

USES=eigen:{2,3},run - should be used when the port doesn't use Eigen 
during build, but installs headers that depend on Eigen

USES=eigen:{2,3},build,run - should be used when the port both uses 
Eigen during build, and installs headers that depend on Eigen

It might not be obvious that 'run' should be used when the installed 
headers use it.


3. Maybe USES=eigen:{2,3},build should conflict with NO_BUILD=yes, as 
these are incompatible conditions? It seems like this could easily catch 
some mistakes.


Thanks,

Yuri