From owner-freebsd-rc@FreeBSD.ORG Mon Aug 10 05:35:34 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30573106564A for ; Mon, 10 Aug 2009 05:35:34 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id BE3AD8FC20 for ; Mon, 10 Aug 2009 05:35:33 +0000 (UTC) Received: (qmail 15354 invoked by uid 399); 10 Aug 2009 05:35:29 -0000 Received: from localhost (HELO ?192.168.0.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 10 Aug 2009 05:35:29 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Date: Sun, 9 Aug 2009 22:34:55 -0700 (PDT) From: Doug Barton To: d@delphij.net In-Reply-To: <4A7FAA42.4030607@delphij.net> Message-ID: References: <4A7B2792.4090803@delphij.net> <4A7B487B.8060303@FreeBSD.org> <4A7F948A.2040602@delphij.net> <4A7F9EC6.9090605@FreeBSD.org> <4A7FAA42.4030607@delphij.net> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-rc@FreeBSD.org Subject: Re: [RFC] script for binding ARP <-> IP pairs X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2009 05:35:34 -0000 On Sun, 9 Aug 2009, Xin LI wrote: > Hi, Doug, > > Doug Barton wrote: >> Xin LI wrote: >> >>> Thanks for your comments, I have put together the revised patch, along >>> with rc.conf.5 and defaults/rc.conf changes. >> >> Glad to help. This looks fine except that you need an entry for >> static_arp_enable in defaults rc.conf and rc.conf.5. > > This script does not require the enable knob. If the static_arp_pairs > is not empty then the script would add the entries, otherwise it will > not do that. Do you think we need an "enable" knob for it? I can add > it but I don't feel strongly for the idea, since it would make a > redundant entry to represent the same semantic. I missed the fact that you're not using rcvar. I'm sort of ambivalent about that, as I prefer things to be consistent, but I'm not actively opposed to it. If no one else has an objection go ahead and send it to -net. Doug -- This .signature sanitized for your protection