From owner-freebsd-current@FreeBSD.ORG Sat Apr 10 09:58:40 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A8B716A4CF for ; Sat, 10 Apr 2004 09:58:40 -0700 (PDT) Received: from noname.csdl.lt (noname.csdl.lt [194.176.40.182]) by mx1.FreeBSD.org (Postfix) with SMTP id 84DB343D1F for ; Sat, 10 Apr 2004 09:58:39 -0700 (PDT) (envelope-from paulius@kaktusas.org) Received: (qmail 42298 invoked by uid 1000); 10 Apr 2004 16:58:38 -0000 Date: Sat, 10 Apr 2004 19:58:38 +0300 From: Paulius Bulotas To: freebsd-current@freebsd.org Message-ID: <20040410165838.GB30395@kaktusas.org> Mail-Followup-To: freebsd-current@freebsd.org References: <20040410103600.GA12488@kaktusas.org> <20040410150936.GA30395@kaktusas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040410150936.GA30395@kaktusas.org> X-URL: http://www.kaktusas.org/ Subject: Re: buildworld fails on src/sys/net80211/ieee80211_ioctl.c with opt_ipx.h not found X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2004 16:58:40 -0000 Hi again ;) can someone commit the following patch (by Alex Lyashkov): <<< cut here --- src/sys/modules/wlan/Makefile.orig Sat Apr 10 19:10:22 2004 +++ src/sys/modules/wlan/Makefile Sat Apr 10 19:19:25 2004 @@ -5,9 +5,12 @@ KMOD= wlan SRCS= ieee80211.c ieee80211_crypto.c ieee80211_input.c ieee80211_ioctl.c \ ieee80211_node.c ieee80211_output.c ieee80211_proto.c -SRCS+= bus_if.h device_if.h opt_inet.h +SRCS+= bus_if.h device_if.h opt_inet.h opt_ipx.h opt_inet.h: echo "#define INET 1" > opt_inet.h + +opt_ipx.h: + echo "#define IPX 1" > opt_ipx.h .include <<< cut here ;) since I can confirm my assumption, that building world and kernel+modules works, and building world+modules and kernel fails. This patch should fix that, and makes wlan/Makefile to act as sys/modules/if_ef/Makefile . Thanks ;) Paulius On 04 04 10, Paulius Bulotas wrote: > On 04 04 10, Conrad Sabatier wrote: > > On 10-Apr-2004 Paulius Bulotas wrote: > > > buildworld fails on src/sys/net80211/ieee80211_ioctl.c with opt_ipx.h > > > being not found. Since this change is 10 days old, maybe I've missed > > > something in mailing list? > > > Maybe the fix should be #ifdef'ing #include "opt_inet.h" and "opt_ipx.h" > > > accordingly with #ifdef IPX and #ifdef INET? > > > > You mean, I'm *not* the only one seeing this problem? :-) > > > > My report on this went completely ignored, so I finally assumed "it must just > > be me". :-) > > > > It seems to me a simple insert in the Makefile (as seen in other locations) > > would take care of this: > > > > echo "#define IPX 1" > opt_ipx.h > > > > Why is this still broken??? > > are you compiling modules with world and not with kernel? > > since opt_ipx.h probably should be created from some IPX protocol > initialisation (if it's enabled in kernel config?), although I can't > find anything related (or don't know how to look ;) > > In sys/modules/if_ef/Makefile opt_ipx.h is created (since > sys/net/if_ef.c uses opt_ipx.h and #ifdef IPX), > in sys/modules/wlan/Makefile opt_ipx.h is not created (why?), but > sys/net80211/* still compiles ok for most of people??? Something not > right here ;)