From owner-svn-src-all@freebsd.org Fri Feb 17 00:22:00 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 96360CE1340; Fri, 17 Feb 2017 00:22:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2A017E9; Fri, 17 Feb 2017 00:22:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qt0-x230.google.com with SMTP id w20so28856794qtb.1; Thu, 16 Feb 2017 16:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PesYfAZAxntcBjh9h6l4SHwOAMw7NEgt3LSbPnMoxx4=; b=ikgKYIFmmVCQrflgFmmwgIzK8nyMFZEhw8TCvAKdbjMA0fDHyttmABG7WwbaBjsyo3 DPCYCwW4NpmKMC486BWMKW4AGjH33zUmNNty612MsAGaXyppG/0iQzPWL1KBQYT9amlx +1PnpXz0grEB/X82sDeSQDEJ+ciJsmYASDpmlEaCUzDQ8mxCl8aOK+16He8zmf4Mdw17 d7Oy0PQi6feyegeHbud7EpEs1fDi/82Xd9VFBjlo9jKqc9orzufDrsQyVu7uUWLRL4fB CCvyTh9OFgs+PbzqB2wKQxk0VbzuHfEi1rEvokhB0V6YinmQdhcR7Iv3xns9t16rNwww UrfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PesYfAZAxntcBjh9h6l4SHwOAMw7NEgt3LSbPnMoxx4=; b=ttrJgOsy6zp+rsyMDKGJ5uOYxQklXW/BDrmgXf8/xBe8J9JdbfxVzeKQAg9XR2+J0o 23STJnMKy74nerChCTwlpPAW5K4pPKob1wKn3ktXxXMD4oz95lX4YkrgpXxyDkr1M2/K a0jy5iCDlwpkKgT2FXd1+tA+VYb5Fmef+EQAFbCVMXIfMmGg2hRhqyrM6qn3WOlmD4Q1 DR63y1ZyEDS3hSr+pRLv848Kk8p8kx8xj0XjHFZiRyNeMJQU5WXtY9/5qatysTwBsvgu 9Q5wJWk7wdCMYLKOueqslqb37uCy5CHH8wCgLeiTVrRSqGzanppyVFMGUW38qsy5AIRV t4Eg== X-Gm-Message-State: AMke39n40wkY9MZb297Hld03gcv45F9DpxVo45AbPeVSCPAU3Vcz0RcA6s8oJA7dUY6xHW93pWdnnPWcUTcQAw== X-Received: by 10.237.34.125 with SMTP id o58mr4786030qtc.95.1487290919412; Thu, 16 Feb 2017 16:21:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.84.230 with HTTP; Thu, 16 Feb 2017 16:21:59 -0800 (PST) In-Reply-To: References: <201702162050.v1GKo1DL014626@repo.freebsd.org> From: Ngie Cooper Date: Thu, 16 Feb 2017 16:21:59 -0800 Message-ID: Subject: Re: svn commit: r313822 - in head/sys: libkern netinet To: Eric van Gyzen Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 00:22:00 -0000 On Thu, Feb 16, 2017 at 4:16 PM, Ngie Cooper wrote: > On Thu, Feb 16, 2017 at 12:50 PM, Eric van Gyzen wrote: >> Author: vangyzen >> Date: Thu Feb 16 20:50:01 2017 >> New Revision: 313822 >> URL: https://svnweb.freebsd.org/changeset/base/313822 >> >> Log: >> Remove inet_ntoa() from the kernel >> >> inet_ntoa() cannot be used safely in a multithreaded environment >> because it uses a static local buffer. Remove it from the kernel. > > Uhmmmm.... did you mean to remove it from netinet/in.h ? This gets > used in userspace too... Oh good grief -- there were 3 definitions??? Ok, I see you deleted the libkern one. Nevermind... carry on! -Ngie $ grep -r inet_ntoa /usr/include/ /usr/include/netinet/in.h:char *inet_ntoa(struct in_addr); /* in libkern */ /usr/include/netinet/in.h:char *inet_ntoa_r(struct in_addr ina, char *buf); /* in libkern */ /usr/include/arpa/inet.h:#define inet_ntoa __inet_ntoa /usr/include/arpa/inet.h:#define inet_ntoa_r __inet_ntoa_r /usr/include/arpa/inet.h:/*const*/ char *inet_ntoa(struct in_addr); /usr/include/arpa/inet.h:char *inet_ntoa_r(struct in_addr, char *buf, socklen_t size); $