From nobody Thu Mar 5 18:44:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fRdk41SHPz6TTxX for ; Thu, 05 Mar 2026 18:44:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fRdk40rFFz42RP for ; Thu, 05 Mar 2026 18:44:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772736268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=urHMBuQCfUCd8ZD2iYoU9dWNAtwvHPVSIsif7W7CHtU=; b=qzTnRm1hMpr/0YY5NfgrJjN3TrFXQoLZ1vKS9kw0DPqay/cs/hc25KdKn5nwx5jqeOhN3B WBLtBMemFcTiAKBWhc0ImgzUcVa3zUYdLEzDoxL2cuUXWB2z6ZBTqE2kfJU6c3Yb1QSVln VWMcGoCiLm+iDTrcYZNyKM1gxL5ogUuFLdjKVZfQgpJJp8TdkPrRKl19/Pu+KwfgzN4Fsn +GTBu6yt9Jj2RXQ98M5K6w5ih5fIyzB8pXEqBXRdEX1oUuhcYHvufrOSBHUx5idATMs1oE J5MYUaCcVW5nKrq3IFMQoVl3m7mv+s7Q8knrlNog5G5G9W7qQGmzep153SvKPg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772736268; a=rsa-sha256; cv=none; b=G67uZF2O7nBKYmVmDMg+osOgAHjY1lvGwC3CKULg5bq4mZMJnfi5tZCLlfg8qT8ngVU9T0 vAJpD0ZBw7rJIZgsCe/Niw0qhRx+T3lqtOylLI4jNXpTPa1GYQ/srkk/AujFc9akGZ4Z8S C6Y2oss9SHL3608Qcpf1SWZgSgvyLUuVvNX82zinatuU3IaAd0xGHdx2MhX5OMclQqMMyD iUPMhU/h29jY5cBPgFENNf48SXgXJkA62HibyJKibLN4Z5ZnHCEbXZ8z6OzsWTbtK7FxqS 9w6JA8/gsJMJoPn+Wrmn/dxSLXJg8GcweGZpZWlGKL0VH5WT6yOaMPR+OXr+bw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772736268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=urHMBuQCfUCd8ZD2iYoU9dWNAtwvHPVSIsif7W7CHtU=; b=hMbDGcORwWCZ34W2ibe9t9VFePgfx4kveTrXGm8cZbqiz8vaY/4xur5/QHmc5lceyM/Sk8 qgtWWmjShw4wiDlZYvftkOrNMGlyKvE2CPczcAccokJASTa9ZeTmSXKADKbnee9e1u+ArS y9w2qgWLQv1S7/t36EExtMgam7qmt96noTYuX5SIIiLTxl9PjE3J3XlNHBvxOCKKg7GaGL ojbp0VVaEzxXTg3Ky6KoRljrDGM2E2XrEj35GanfvzmPpJjPTv8XH69yCrTyal7t17Weyx t36mNDlMIpIyINMVxc9iJtjhfAWCp4DtlFqcRmR7D7qJOEeE51gMNrOrwE0ITA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fRdk36tVfzpFT for ; Thu, 05 Mar 2026 18:44:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47158 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Mar 2026 18:44:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 6feb16b77e7d - main - witness: report a thread that can't sleep in WITNESS_WARN List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6feb16b77e7df470c635bc3af65d448fd37deb10 Auto-Submitted: auto-generated Date: Thu, 05 Mar 2026 18:44:27 +0000 Message-Id: <69a9cf0b.47158.66f48a02@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=6feb16b77e7df470c635bc3af65d448fd37deb10 commit 6feb16b77e7df470c635bc3af65d448fd37deb10 Author: Gleb Smirnoff AuthorDate: 2026-03-05 18:43:17 +0000 Commit: Gleb Smirnoff CommitDate: 2026-03-05 18:43:17 +0000 witness: report a thread that can't sleep in WITNESS_WARN Although this is not related to locking, but seems to be the right place to catch violators, given that WITNESS_WARN is already used widely in the kernel. Reviewed by: kib, markj Differential Revision: https://reviews.freebsd.org/D55316 --- sys/kern/subr_witness.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/kern/subr_witness.c b/sys/kern/subr_witness.c index 7437a7e238f0..85dc0c321797 100644 --- a/sys/kern/subr_witness.c +++ b/sys/kern/subr_witness.c @@ -2136,6 +2136,15 @@ witness_warn(int flags, struct lock_object *lock, const char *fmt, ...) n += witness_list_locks(&lock_list, printf); } else sched_unpin(); + + if (td->td_no_sleeping != 0 && (flags & WARN_SLEEPOK) != 0) { + va_start(ap, fmt); + vprintf(fmt, ap); + va_end(ap); + printf(" with %d sleep inhibitors\n", td->td_no_sleeping); + n += td->td_no_sleeping; + } + if (flags & WARN_PANIC && n) kassert_panic("%s", __func__); else