Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Nov 2012 18:12:54 -0500
From:      Eitan Adler <eadler@freebsd.org>
To:        Chris Rees <utisoft@gmail.com>
Cc:        jail@freebsd.org, Mateusz Guzik <mjguzik@gmail.com>, "freebsd-rc@freebsd.org" <freebsd-rc@freebsd.org>
Subject:   Re: jail: unknown parameter: ip6.addr
Message-ID:  <CAF6rxg=E6VwtPM6Xp8no7pUwR4T6fUxmQZm5A6u4YC%2BzdCvKjA@mail.gmail.com>
In-Reply-To: <CADLo839pJxZuw2k0kMCAtVh7PTEcF4gbjM2p1Fd9hf71OZmKhg@mail.gmail.com>
References:  <CADLo83-L-GuuK_aqyzNEriRMJsDczroujt5kHHazKDh_4qWeyw@mail.gmail.com> <CADLo839pJxZuw2k0kMCAtVh7PTEcF4gbjM2p1Fd9hf71OZmKhg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11 November 2012 07:30, Chris Rees <utisoft@gmail.com> wrote:
> On 10/11/2012, Chris Rees <utisoft@gmail.com> wrote:
>> [adding rc@, please keep me CCd as I'm not in jail@]
>>
>> On Thu, 2012-11-08 at 02:27 +0100, Mateusz Guzik wrote:
>>> On Wed, Nov 07, 2012 at 03:39:26PM -0500, Mike Jakubik wrote:
>>> > Hello,
>>> >
>>> > I just updated a server to latest stable and my jails no longer start,
>>> > troubleshooting the startup script shows us that the parameter ip6.addr
>>> > is unknown, this system is compiled without INET6.
>>> [..]
>>> > + tail +2 /tmp/jail.PJ5ji3QH/jail.8101
>>> > jail: unknown parameter: ip6.addr
>>>
>>> Try this (lightly tested):
>>> http://people.freebsd.org/~mjg/patches/rc-jail-ip-arg.diff
>>>
>>> Basically the idea is to pass ip4.addr and ip6.addr only when respective
>>> addresses are specified in configuration.
>>
>>
>> Since we've had confirmation that the patch works, a much faster way
>> is to use sh's variable substitution magic, which also means a much
>> smaller change:
>>
>> -            ip4.addr=\"${_addrl}\" ip6.addr=\"${_addr6l}\"
>> ${_parameters} command=${_exec_start} > ${_tmp_jail} 2>&1 \
>> +            ${_addrl:+ip4.addr=\"${_addrl}\"}
>> ${_addr6l:+ip6.addr=\"${_addr6l}\"} ${_parameters}
>> command=${_exec_start} > ${_tmp_jail} 2>&1 \
>>
>> I'll get a patch together later
>>
>
> Patch as promised-- please would you test and confirm?
>
> http://www.bayofrum.net/~crees/patches/rc-jail-ip-arg-shvars.diff

ack


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=E6VwtPM6Xp8no7pUwR4T6fUxmQZm5A6u4YC%2BzdCvKjA>