From owner-freebsd-rc@FreeBSD.ORG Mon Nov 12 23:13:26 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D7AB3C95 for ; Mon, 12 Nov 2012 23:13:26 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4BC0E8FC0C for ; Mon, 12 Nov 2012 23:13:25 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id gg13so1740732lbb.13 for ; Mon, 12 Nov 2012 15:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=Htd0tzct7vqkPv4+8tU4HY/F4XRjMy0vJue4wu2QCl4=; b=EKX7gzqK1fXiAlVckI3R2Cp4silsdabRBLtS/ax6jDUMJ905ZLTWE/uD5tfH8v0mi5 hLk0c1XBwIhqTJSrlCvWvTIoDP85x8CPbwM0MTVdBSFSfgyjjYfAw78IRatD1VJCQ+kB GmhcZ0ciJDGyA2bFQyayspuQ953vTLOLLzaTs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=Htd0tzct7vqkPv4+8tU4HY/F4XRjMy0vJue4wu2QCl4=; b=iNHXyedasla8n2AeNz1tVYn1RH6GclA0rXeodG0ALWPZzrSiX2qtH6Eq0ciTDGY0q8 bDbRWJCXJ5nIQXqWwVmiH60XP6RDsc0q7C0UmBi12zV3+volLq1KRCUCXaN+MZI1/ReD xH5M1pFyDNZTM4BjIr4mFs+0YnjveIaUNQkxvYGSwu1J0BQTRQ1zjtmo88+xFYaQLzf+ +lPNQMH5ETPnjNMDqxI/X/NHjdeSyF7JPCuiVzzcJYNVMG41n5HiiKvm2gg2brNe/0JO VB6czKQBH2C0NdbjhUcZLI3WTO71xLb6VmJhb22P9PVkrKEKW+dAwRLzyoRJ9QR4ENoT leNg== Received: by 10.112.37.7 with SMTP id u7mr8527255lbj.30.1352762004783; Mon, 12 Nov 2012 15:13:24 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.166 with HTTP; Mon, 12 Nov 2012 15:12:54 -0800 (PST) In-Reply-To: References: From: Eitan Adler Date: Mon, 12 Nov 2012 18:12:54 -0500 X-Google-Sender-Auth: f39-jfzp3fbvs9lUflY7gnMlEJQ Message-ID: Subject: Re: jail: unknown parameter: ip6.addr To: Chris Rees Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQl+uWy9pkMZ8AF0czxwSIIvCAI5gq7wyaFWiC1rZpQD0lffPtgmXUIvyHH8ssWcMF/qj3/b Cc: jail@freebsd.org, Mateusz Guzik , "freebsd-rc@freebsd.org" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2012 23:13:27 -0000 On 11 November 2012 07:30, Chris Rees wrote: > On 10/11/2012, Chris Rees wrote: >> [adding rc@, please keep me CCd as I'm not in jail@] >> >> On Thu, 2012-11-08 at 02:27 +0100, Mateusz Guzik wrote: >>> On Wed, Nov 07, 2012 at 03:39:26PM -0500, Mike Jakubik wrote: >>> > Hello, >>> > >>> > I just updated a server to latest stable and my jails no longer start, >>> > troubleshooting the startup script shows us that the parameter ip6.addr >>> > is unknown, this system is compiled without INET6. >>> [..] >>> > + tail +2 /tmp/jail.PJ5ji3QH/jail.8101 >>> > jail: unknown parameter: ip6.addr >>> >>> Try this (lightly tested): >>> http://people.freebsd.org/~mjg/patches/rc-jail-ip-arg.diff >>> >>> Basically the idea is to pass ip4.addr and ip6.addr only when respective >>> addresses are specified in configuration. >> >> >> Since we've had confirmation that the patch works, a much faster way >> is to use sh's variable substitution magic, which also means a much >> smaller change: >> >> - ip4.addr=\"${_addrl}\" ip6.addr=\"${_addr6l}\" >> ${_parameters} command=${_exec_start} > ${_tmp_jail} 2>&1 \ >> + ${_addrl:+ip4.addr=\"${_addrl}\"} >> ${_addr6l:+ip6.addr=\"${_addr6l}\"} ${_parameters} >> command=${_exec_start} > ${_tmp_jail} 2>&1 \ >> >> I'll get a patch together later >> > > Patch as promised-- please would you test and confirm? > > http://www.bayofrum.net/~crees/patches/rc-jail-ip-arg-shvars.diff ack -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams