From owner-freebsd-current  Tue Jun 18 16:31:09 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id QAA09400
          for current-outgoing; Tue, 18 Jun 1996 16:31:09 -0700 (PDT)
Received: from genesis.atrad.adelaide.edu.au (genesis.atrad.adelaide.edu.au [129.127.96.120])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id QAA09393;
          Tue, 18 Jun 1996 16:31:05 -0700 (PDT)
Received: from msmith@localhost by genesis.atrad.adelaide.edu.au (8.6.12/8.6.9) id JAA26773; Wed, 19 Jun 1996 09:32:39 +0930
From: Michael Smith <msmith@atrad.adelaide.edu.au>
Message-Id: <199606190002.JAA26773@genesis.atrad.adelaide.edu.au>
Subject: Re: xditview
To: jhs@freebsd.org
Date: Wed, 19 Jun 1996 09:32:38 +0930 (CST)
Cc: current@freebsd.org, jkh@freebsd.org
In-Reply-To: <199606181014.MAA01844@vector.jhs.no_domain> from "Julian H. Stacey" at Jun 18, 96 12:14:49 pm
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Julian H. Stacey stands accused of saying:
> 
> It seems xditview was removed from src/gnu/usr.bin/groff/
> (with today's just received ctm patch: src-cur.1896)
> 
> I seem to recall someone complaining it wouldnt compile if there was no
> X tree resident, could it have been removed just because of that ? !

Actually, it would cause 'make world' to fail if /usr/X11R6 were present
but not complete (eg. only libraries were present, say for running emacs),
or not writable (eg. mounted readonly via NFS), or if you built on a
machine with no X and then tried 'make reinstall' onto one that had
X, the 'reinstall' would fail.

> A better solution may be something like:
> src/gnu/usr.bin/groff/Makefile:
> 	.if exists(${X11BASE}/include)
> 	.if exists(${X11BASE}/lib)
> 	SUBDIR +=xditview

You would need to add a writability test too.  I would have been happy
with the build or install failing and being ignored, but I couldn't 
come up with a way for it to be done tidily.

> Julian H. Stacey	jhs@freebsd.org		http://www.freebsd.org/~jhs/

-- 
]] Mike Smith, Software Engineer        msmith@atrad.adelaide.edu.au    [[
]] Genesis Software                     genesis@atrad.adelaide.edu.au   [[
]] High-speed data acquisition and      (GSM mobile) 0411-222-496       [[
]] realtime instrument control          (ph/fax)  +61-8-267-3039        [[
]] Collector of old Unix hardware.      "Where are your PEZ?" The Tick  [[