From owner-cvs-src@FreeBSD.ORG Mon Dec 10 18:02:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84A8616A419; Mon, 10 Dec 2007 18:02:39 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 452D213C459; Mon, 10 Dec 2007 18:02:39 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id lBAI2cL5094279; Mon, 10 Dec 2007 10:02:38 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id lBAI2cfl094278; Mon, 10 Dec 2007 10:02:38 -0800 (PST) (envelope-from obrien) Date: Mon, 10 Dec 2007 10:02:38 -0800 From: "David O'Brien" To: Kirill Ponomarew Message-ID: <20071210180238.GA93589@dragon.NUXI.org> References: <200712091101.lB9B1w0C070261@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200712091101.lB9B1w0C070261@repoman.freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install Makefile src/usr.sbin/pkg_install/add pkg_add.1 src/usr.sbin/pkg_install/create pkg_create.1 src/usr.sbin/pkg_install/delete pkg_delete.1 src/usr.sbin/pkg_install/info pkg_info.1 src/usr.sbin/pkg_install/search Makefile pkg_search.1 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2007 18:02:39 -0000 On Sun, Dec 09, 2007 at 11:01:58AM +0000, Kirill Ponomarew wrote: > Backout previous commit, since it's done without maintainers > approval. These changes were approved by adding it as port to > ports/ tree, but not for src/. You know - you should have asked me my motivation for adding this here. I strongly feel it should be in the base system. The existing pkg_* tools in the src/ are to get you started. I can see how one could feel there is beauty in hosting package tools within the ports collection itself. However, we need to have sufficient pkg_* tools in src to get one started. That is why pkg_add is in src/. We owe it to our users to make it easy to add or install a port. In order for a user to do that, they need to know the name (if pkg_add -r), or location (if building themselves). That is the problem pkg_search solves. In fact someone told me about a new port I would find useful. In the end they gave me the wrong path to where it lives in /usr/ports and it took more effort than it should have to figure out where it lives. With pkg_search (in the base system) it would have taken only a second. If something like pkg_search doesn't belong in src/, then why does pkg_delete, pkg_sign, pkg_create, or pkg_version? > I talked to PR submitter and miwi@ > some days ago and explained the reasons for it, the both were agree > to add it to ports/ only. If this was on a public list I missed it. What are you reasons for denying it? I would also like an opinion on what Portmgr must approve. Anything in the base system that is Ports Collection related? Anything that changes the existing pkg_* applications used by /usr/ports/Mk/*? [that is what I thought was covered] -- David