Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Dec 2021 11:22:27 +0100
From:      Stefan Esser <se@freebsd.org>
To:        Antoine Brodin <antoine@freebsd.org>, Konstantin Belousov <kib@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, FreeBSD Ports Management Team <portmgr@freebsd.org>
Subject:   Re: git: e2650af157bc - main - Make CPU_SET macros compliant with other implementations
Message-ID:  <d1553b68-23dd-128e-6ac0-6c3c1f66c7cd@freebsd.org>
In-Reply-To: <CAALwa8m3u3xrO3N0j8um57qGTVnMEQwx1gP2YxJbzE5%2BLhbsWA@mail.gmail.com>
References:  <202112301154.1BUBsR1q017491@gitrepo.freebsd.org> <CAALwa8m3u3xrO3N0j8um57qGTVnMEQwx1gP2YxJbzE5%2BLhbsWA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------TQ84wRweK4tT2dlhORHTEXDF
Content-Type: multipart/mixed; boundary="------------N90XZBVQMQXuyl2lIsBaUBeR";
 protected-headers="v1"
From: Stefan Esser <se@freebsd.org>
To: Antoine Brodin <antoine@freebsd.org>,
 Konstantin Belousov <kib@FreeBSD.org>
Cc: src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org,
 FreeBSD Ports Management Team <portmgr@freebsd.org>
Message-ID: <d1553b68-23dd-128e-6ac0-6c3c1f66c7cd@freebsd.org>
Subject: Re: git: e2650af157bc - main - Make CPU_SET macros compliant with
 other implementations
References: <202112301154.1BUBsR1q017491@gitrepo.freebsd.org>
 <CAALwa8m3u3xrO3N0j8um57qGTVnMEQwx1gP2YxJbzE5+LhbsWA@mail.gmail.com>
In-Reply-To: <CAALwa8m3u3xrO3N0j8um57qGTVnMEQwx1gP2YxJbzE5+LhbsWA@mail.gmail.com>

--------------N90XZBVQMQXuyl2lIsBaUBeR
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am 31.12.21 um 09:01 schrieb Antoine Brodin:
> On Thu, Dec 30, 2021 at 11:54 AM Stefan E=C3=9Fer <se@freebsd.org> wrot=
e:
>>
>> The branch main has been updated by se:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=3De2650af157bc7489deaf2c9=
054995f0f88a6e5da
>>
>> commit e2650af157bc7489deaf2c9054995f0f88a6e5da
>> Author:     Stefan E=C3=9Fer <se@FreeBSD.org>
>> AuthorDate: 2021-12-30 11:20:32 +0000
>> Commit:     Stefan E=C3=9Fer <se@FreeBSD.org>
>> CommitDate: 2021-12-30 11:20:32 +0000
>>
[...]
>>     Ports that have added -D_WITH_CPU_SET_T to build on -CURRENT do
>>     no longer require that option.
>>
>>     The FreeBSD version has been bumped to 1400046 to reflect this
>>     incompatible change.
>>
>>     Reviewed by:    kib
>>     MFC after:      2 weeks
>>     Relnotes:       yes
>>     Differential Revision:  https://reviews.freebsd.org/D33451
>=20
> Hi,
>=20
> This breaks a lot of ports,  like  lang/python38.
> Could these kinds of changes on public headers be tested with an
> exp-run,  and reverted in the mean-time?

I'm sorry for the breakage. The commit had the goal to lessen
port build problems caused by the misled assumptions that the
port was being built on a GLIBC based system.

In the case of the Python language ports, one additional macro
was required and has been added in commit cb65d4432aed11.

Since the official package builders have not been upgraded to
a -CURRENT with this change, they are not affected. But I'll
watch the failed build logs on beefy18.


I'm not opposed to a revert and exp-run, but I'm convinced that
any fall-out from this change is easily fixed, and I'm willing
to quickly fix any ports or base system components affected.

Regards, STefan

--------------N90XZBVQMQXuyl2lIsBaUBeR--

--------------TQ84wRweK4tT2dlhORHTEXDF
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmHO2eMFAwAAAAAACgkQR+u171r99URr
bwgAjdWHJFy79NqvAEDcJtCgbgRDwAJmmV5K5BNIh6VySnW0iOiUy938XJBhmvY26tjRZhgAu/XT
5pIEqxMS6ZS3IbEPSc+/5qNs1dGnz+BDfWqfah8e/BwTjZD/FAxWmAYkPN29U2FvosXLyypx6ZF7
+ZrU4t85JQ0u0sOc9NqhEaI3E9uvMlKwYEQeWGHSKzHWyZ7nSSI1hUEtaB39lHsckFqqR40YJ56f
kUTtSEnoAZszrN8LxHkkFAqA3o0uiTsQmR1hKiQP6YwP5AoAQ2H5t+sUR0Rj3eXUpr2tINGFCDMX
fnZTZmhvXCFSZq3zQ2OfLLJiNK1IL4T0gx1XWh1oPA==
=CdwC
-----END PGP SIGNATURE-----

--------------TQ84wRweK4tT2dlhORHTEXDF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d1553b68-23dd-128e-6ac0-6c3c1f66c7cd>