From owner-freebsd-current Fri Oct 11 5:17:35 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC4F037B404 for ; Fri, 11 Oct 2002 05:17:33 -0700 (PDT) Received: from relay1.macomnet.ru (relay1.macomnet.ru [195.128.64.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0263B43EA9 for ; Fri, 11 Oct 2002 05:17:27 -0700 (PDT) (envelope-from maxim@macomnet.ru) Received: from news1.macomnet.ru (news1.macomnet.ru [195.128.64.14]) by relay1.macomnet.ru (8.11.6/8.11.6) with ESMTP id g9BCHKK875483 for ; Fri, 11 Oct 2002 16:17:20 +0400 (MSD) Date: Fri, 11 Oct 2002 16:17:20 +0400 (MSD) From: Maxim Konovalov To: freebsd-current@freebsd.org Subject: pw_scan() allows empty login names Message-ID: <20021011160827.Y29119-100000@news1.macomnet.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hello, Is it intentional? Here is a patch: Index: lib/libc/gen/pw_scan.c =================================================================== RCS file: /home/ncvs/src/lib/libc/gen/pw_scan.c,v retrieving revision 1.23 diff -u -r1.23 pw_scan.c --- lib/libc/gen/pw_scan.c 2 Oct 2002 07:02:46 -0000 1.23 +++ lib/libc/gen/pw_scan.c 11 Oct 2002 11:36:19 -0000 @@ -78,6 +78,8 @@ pw->pw_fields = 0; if (!(pw->pw_name = strsep(&bp, ":"))) /* login */ goto fmt; + if (pw->pw_name[0] == '\0') + goto fmt; root = !strcmp(pw->pw_name, "root"); if (pw->pw_name[0] && (pw->pw_name[0] != '+' || pw->pw_name[1] == '\0')) pw->pw_fields |= _PWF_NAME; %%% -- Maxim Konovalov, MAcomnet, Internet Dept., system engineer phone: +7 (095) 796-9079, mailto:maxim@macomnet.ru To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message