Date: Tue, 02 Nov 2021 02:37:03 +0900 (JST) From: Yasuhiro Kimura <yasu@FreeBSD.org> To: garga@FreeBSD.org Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 67be9a912d61 - main - devel/git: Update to 2.33.1 Message-ID: <20211102.023703.1883557663869848680.yasu@FreeBSD.org> In-Reply-To: <1e6ee54f-7917-49dc-ae65-44d4f5e71291@FreeBSD.org> References: <202110300623.19U6NOPO023944@gitrepo.freebsd.org> <1e6ee54f-7917-49dc-ae65-44d4f5e71291@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Renato. From: Renato Botelho <garga@FreeBSD.org> Subject: Re: git: 67be9a912d61 - main - devel/git: Update to 2.33.1 Date: Mon, 1 Nov 2021 11:55:24 -0300 > Yasuhiro, > > Thanks for pushing the upgrade. One small note, when HTMLDOCS option > is set, it installs a small txt file with notes for each version. The > patch you pushed is missing one pkg-plist entry for that: > > %%HTMLDOCS%%%%DOCSDIR%%/RelNotes/2.33.1.txt Thank you for reporting it. And sorry for breackage. I pushed the fix. But at the same time another problem is found. Before submitting update to 2.33.1, I did poudriere build test with HTMLDOCS is ON. And poudriere didn't report any error at check-plist stage. So I removed all lines starting with '%%HTMLDOCS%%' from pkg-plist and did test build again. Then check-plist didn't report any error either. That is, `make check-plist` doesn't report any plist error about files installed when HTMLDOCS is enabled. It doesn't happen with other options. For example if I removes line starting with '%%CURL%%', then `make check-plist` detects plist error successfully. Though I'm not sure exactly when, I remember plist error related to HTMLDOCS option was successfully detected when I created patch to updated the port previously. So it's very strange that only plist error related to HTMLDOCS become undetected. --- Yasuhiro Kimura
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211102.023703.1883557663869848680.yasu>