Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Nov 2014 10:51:34 +0000 (UTC)
From:      Rene Ladan <rene@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r372253 - in head/www/chromium: . files
Message-ID:  <201411071051.sA7ApYfV061430@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rene
Date: Fri Nov  7 10:51:33 2014
New Revision: 372253
URL: https://svnweb.freebsd.org/changeset/ports/372253
QAT: https://qat.redports.org/buildarchive/r372253/

Log:
  www/chromium:
  - fix crash on startup on systems which do not have libexecinfo in base
    (typically 8.X and 9.X)
  - conditionally bump PORTREVISION
  
  PR:		ports/193610
  Submitted by:	Rob Belics
  Patch by:	Tomek
  MFH:		2014Q4

Added:
  head/www/chromium/files/extra-patch-fixup-ffmpeg   (contents, props changed)
Modified:
  head/www/chromium/Makefile

Modified: head/www/chromium/Makefile
==============================================================================
--- head/www/chromium/Makefile	Fri Nov  7 10:47:34 2014	(r372252)
+++ head/www/chromium/Makefile	Fri Nov  7 10:51:33 2014	(r372253)
@@ -165,6 +165,13 @@ GYP_DEFINES+=	disable_sse2=1
 EXTRA_PATCHES+=	${FILESDIR}/extra-patch-libusb-pc
 .endif
 
+# pointed out by "Tomek" on freebsd-chromium@
+.if !exists(/usr/lib/libexecinfo.so)
+CFLAGS+=	-fno-omit-frame-pointer
+EXTRA_PATCHES+=	${FILESDIR}/extra-patch-fixup-ffmpeg
+PORTREVISION=	1
+.endif
+
 .if ${PORT_OPTIONS:MTEST}
 .include "Makefile.tests"
 ALL_TARGET+=	${TEST_TARGETS}

Added: head/www/chromium/files/extra-patch-fixup-ffmpeg
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/chromium/files/extra-patch-fixup-ffmpeg	Fri Nov  7 10:51:33 2014	(r372253)
@@ -0,0 +1,18 @@
+--- third_party/ffmpeg/ffmpeg.gyp.orig	2014-10-27 20:27:40.000000000 +0100
++++ third_party/ffmpeg/ffmpeg.gyp	2014-11-06 22:53:10.000000000 +0100
+@@ -213,6 +213,15 @@
+               'cflags!': [
+                 '-fno-omit-frame-pointer',
+               ],
++              # "Tomek" from freebsd-chromium@ figured this out, rene is
++              # puzzled why this is needed. Fixes runtime on FreeBSD < 10
++              'cflags_c': [
++                '-fomit-frame-pointer',
++              ],
++              'cflags_cc': [
++                '-fomit-frame-pointer',
++              ],
++              # back to upstream code
+               'debug_extra_cflags!': [
+                 '-fno-omit-frame-pointer',
+               ],



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201411071051.sA7ApYfV061430>